config-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] config.sub is not idempotent


From: John Ericson
Subject: [PATCH] config.sub is not idempotent
Date: Tue, 24 Jul 2018 23:57:27 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

A canonical form is defined as one that maps to itself. I decided to check whether the config.sub test suite's canonical configurations actually did, and many of them did not, or weren't even accepted at all!

I checked this by extending the test suite with a new function, which is the most important part of this patch. I also hurriedly fixed config.sub so that it passed the improved testsuite. Those fixes however should be checked over as I wasn't always sure on the best way to fix things (e.g. what vendors to allow)

Ben, you might notice that many of these fixes overlap with my deduplication patch. That is because the duplication necessary frequently is forgotten, leading to bugs. I point this out to show how deduplication is not only a good idea for cleanliness, but also for correctness. Let's try to land this (with improve fixed) before that, however, as I'll be able to redo the deduplication patch with higher quality way once this is dealt with.

Thanks,

John

Attachment: 0001-config.sub-Make-idemopotent.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]