[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/2] av_ff_common: use mcache
From: |
Eric Wong |
Subject: |
[PATCH 2/2] av_ff_common: use mcache |
Date: |
Mon, 4 Sep 2023 06:21:52 +0000 |
As with soxi(1), waiting for ffprobe(1) or avprobe(1) is still
an expensive operation despite Process.spawn being optimized to
use vfork(2).
---
lib/dtas/source/av.rb | 1 +
lib/dtas/source/av_ff_common.rb | 19 ++++++++++++++++---
lib/dtas/source/ff.rb | 1 +
3 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/lib/dtas/source/av.rb b/lib/dtas/source/av.rb
index 39cad6c..823b29f 100644
--- a/lib/dtas/source/av.rb
+++ b/lib/dtas/source/av.rb
@@ -20,6 +20,7 @@ class DTAS::Source::Av # :nodoc:
def initialize
command_init(AV_DEFAULTS)
+ @mcache = nil
@av_ff_probe = "avprobe"
end
diff --git a/lib/dtas/source/av_ff_common.rb b/lib/dtas/source/av_ff_common.rb
index 332a0bb..0c84b2f 100644
--- a/lib/dtas/source/av_ff_common.rb
+++ b/lib/dtas/source/av_ff_common.rb
@@ -21,10 +21,23 @@ module DTAS::Source::AvFfCommon # :nodoc:
attr_reader :format
attr_reader :duration
+ CACHE_KEYS = [ :@duration, :@probe_harder, :@comments, :@astreams,
+ :@format ].freeze
+
+ def mcache_lookup(infile)
+ (@mcache ||= DTAS::Mcache.new).lookup(infile) do |input, dst|
+ tmp = source_file_dup(infile, nil, nil)
+ tmp.av_ff_ok? or return nil
+ CACHE_KEYS.each { |k| dst[k] = tmp.instance_variable_get(k) }
+ dst
+ end
+ end
+
def try(infile, offset = nil, trim = nil)
- rv = source_file_dup(infile, offset, trim)
- rv.av_ff_ok? or return
- rv
+ ent = mcache_lookup(infile) or return
+ ret = source_file_dup(infile, offset, trim)
+ CACHE_KEYS.each { |k| ret.instance_variable_set(k, ent[k]) }
+ ret
end
def __parse_astream(cmd, stream)
diff --git a/lib/dtas/source/ff.rb b/lib/dtas/source/ff.rb
index 687cd18..491e580 100644
--- a/lib/dtas/source/ff.rb
+++ b/lib/dtas/source/ff.rb
@@ -21,6 +21,7 @@ class DTAS::Source::Ff # :nodoc:
def initialize
command_init(FF_DEFAULTS)
+ @mcache = nil
@av_ff_probe = "ffprobe"
end