[debbugs-tracker] bug#31528: closed (patch get-bytevector-n to read more than 4 GB)

[GNU bug Tracking System]

Your message dated Mon, 18 Jun 2018 14:05:16 +0200
with message-id <address@hidden>
and subject line Re: bug#31528: patch get-bytevector-n to read more than 4 GB
has caused the debbugs.gnu.org bug report #31528,
regarding patch get-bytevector-n to read more than 4 GB
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
31528: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31528
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: patch get-bytevector-n to read more than 4 GB Date: Sat, 19 May 2018 13:10:15 +0200

Hi,

I found

(use-modules (rnrs io ports))

(define v (call-with-input-file "EIVE01.DAT" (lambda (port)

  (get-bytevector-n port (* 5 1024 1024 1024)))))

fails due to 'out of range':

ERROR: In procedure get-bytevector-n:

ERROR: Value out of range 0 to 4294967295: 52434042880

 

 The "count" variable was of "unsigned" type (i.e. 32-bit) so I changed it to "size_t" and the problem is solved.

Enclosed is the corresponding patch (using format-patch)

Jan Šmydke

patch
Description: Binary data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#31528: patch get-bytevector-n to read more than 4 GB
>
>
>
>
> Date: 
>
> Mon, 18 Jun 2018 14:05:16 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hello Jan,
>
> Jan Šmydke <address@hidden> skribis:
>
> >  The "count" variable was of "unsigned" type (i.e. 32-bit) so I changed it
> > to "size_t" and the problem is solved.
> >
> > Enclosed is the corresponding patch (using format-patch)
> >
> > Jan Šmydke
> > From 5b72b9d9c3cfa40884594eb1d403ec1d2f477d37 Mon Sep 17 00:00:00 2001
> > From: Jan Smydke <address@hidden>
> > Date: Sat, 19 May 2018 12:48:01 +0200
> > Subject: [PATCH] get-bytevector-n and get-bytevector-n! can now read more than
> >  4 GB: var "count" changed from unsigned to size_t
> >
> > ---
> >  libguile/r6rs-ports.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
>
> Awesome.  I adjusted the commit log to match our conventions and
> committed.
>
> Thank you!
>
> Ludo’.
>
>
> --- End Message ---