--- Begin Message ---
Subject: |
25.2; (setting-constant nil) error in sql.el |
Date: |
Fri, 16 Feb 2018 22:52:28 +0100 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
Hi,
i'm trying to add SQL product by following steps from the introduction
section in the sql.el, but for the settings
:sqli-program
:sqli-login
:sqli-options
it fails with "attemt to set a constant symbol: nil"
In 'emacs -Q' executing it step-by-step:
(require 'sql)
(sql-add-product 'xyz "XyzDB"
'(:free-software t))
(defcustom my-sql-xyz-program "ixyz"
"Command to start ixyz by XyzDB."
:type 'file
:group 'SQL)
;; NEXT STEP FAILS WITH:
;; Debugger entered--Lisp error: (setting-constant nil)
;; sql-set-product-feature(xyz :sqli-program my-sql-xyz-program)
;; eval((sql-set-product-feature (quote xyz) :sqli-program (quote
my-sql-xyz-program)) nil)
(sql-set-product-feature 'xyz
:sqli-program 'my-sql-xyz-program)
;; BUT THIS TWO ARE OK
(sql-set-product-feature 'xyz
:prompt-regexp "^xyzdb> ")
(sql-set-product-feature 'xyz
:prompt-length 7)
--
Denis
--- End Message ---
--- Begin Message ---
Subject: |
Re: bug#30494: 25.2; (setting-constant nil) error in sql.el |
Date: |
Sat, 12 Jan 2019 13:35:14 +0200 |
> From: address@hidden (Pierre Téchoueyres)
> Date: Tue, 08 Jan 2019 23:00:06 +0100
> Cc: address@hidden, address@hidden
>
> >>>> Looks like it's probably just a missing nil check in
> >>>> sql-set-product-feature.
> >>>>
> >>>
> >>> Does the attached patch do the trick ?
> >>>
> >> Any interrest on this ?
> >
> > Ping ! Or if this isn't desired, maybe it's time to close the bug ?
>
> Ping ! Ping !
Sorry for lack of replies so far.
I've now pushed these changes to the master branch, and I'm closing
the bug report. In the future, please be sure to state in the log
message the function(s) where you make changes.
--- End Message ---