[debbugs-tracker] bug#34074: closed (27.0.5; flymake-proc delete temporary directory failed)

[GNU bug Tracking System]

Your message dated Thu, 17 Jan 2019 14:58:09 +0000
with message-id <address@hidden>
and subject line Re: bug#34074: 27.0.5; flymake-proc delete temporary directory 
failed
has caused the debbugs.gnu.org bug report #34074,
regarding 27.0.5; flymake-proc delete temporary directory failed
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34074: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34074
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: 27.0.5; flymake-proc delete temporary directory failed Date: Mon, 14 Jan 2019 10:55:28 +0100

The temporary-file-directory on my host is "/tmp/", current function trancates the first charactor of the directory name, cause the directory not exist error.

Below patch removes the folder separator of the temporary-file-directory, works fine in my environment.

diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el

index 7cdbb266fe..f0b979185e 100644

--- a/lisp/progmodes/flymake-proc.el

+++ b/lisp/progmodes/flymake-proc.el

@@ -886,7 +886,7 @@ can also be executed interactively independently of

 

 (defun flymake-proc--delete-temp-directory (dir-name)

   "Attempt to delete temp dir created by `flymake-proc-create-temp-with-folder-structure', do not fail on error."

-  (let* ((temp-dir    temporary-file-directory)

+  (let* ((temp-dir    (directory-file-name temporary-file-directory))

         (suffix      (substring dir-name (1+ (length temp-dir)))))

 

     (while (> (length suffix) 0)

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#34074: 27.0.5; flymake-proc delete temporary directory failed
>
>
>
>
> Date: 
>
> Thu, 17 Jan 2019 14:58:09 +0000
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt)
>
>
>
>
> 林宝龙 <address@hidden> writes:
>
> > The temporary-file-directory on my host is "/tmp/", current function
> > trancates the first charactor of the directory name, cause the
> > directory not exist error.
> >
> > Below patch removes the folder separator of the temporary-file-directory, 
> > works fine in my environment.
>
> Thanks, I pushed a slightly safer fix in
>
> commit 80cbfb61c5a562d51197d6f3068fa5f4cda432b0
> Author: João Távora <address@hidden>
> Date:   Thu Jan 17 14:38:44 2019 +0000
>
>     Fix flymake-proc--delete-temp-directory if temp dir ends in slash
>
>
>
> --- End Message ---