[debbugs-tracker] bug#34153: closed ([PATCH] Update fish to 3.0.0.)

[GNU bug Tracking System]

Your message dated Mon, 28 Jan 2019 23:13:21 +0100
with message-id <address@hidden>
and subject line Re: [bug#34153] [PATCH] Update fish to 3.0.0.
has caused the debbugs.gnu.org bug report #34153,
regarding [PATCH] Update fish to 3.0.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
34153: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=34153
GNU Bug Tracking System
Contact address@hidden with problems

--- Begin Message --- Subject: [PATCH] Update fish to 3.0.0. Date: Mon, 21 Jan 2019 16:19:29 +0800 User-agent: mu4e 1.0; emacs 26.1

Hi,

This patch series updates fish shell to 3.0.0 and enable fish to source
/etc/profile using fish-foreign-env.

0001-gnu-fish-Update-to-3.0.0.patch
Description: Text Data

0002-gnu-Add-fish-foreign-env.patch
Description: Text Data

0003-gnu-fish-Use-fish-foreign-env-to-source-etc-profile.patch
Description: Text Data

--
Meiyo Peng
https://www.pengmeiyu.com/

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#34153] [PATCH] Update fish to 3.0.0.
>
>
>
>
> Date: 
>
> Mon, 28 Jan 2019 23:13:21 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
>
>
>
>
> Hello Meiyo,
>
> Meiyo Peng <address@hidden> skribis:
>
> > This patch series updates fish shell to 3.0.0 and enable fish to source
> > /etc/profile using fish-foreign-env.
>
> I don’t use Fish so I don’t really have an opinion but it looks
> reasonable to me.  If it breaks, users will yell at you anyway.  ;-)
>
> >>From 8d20b9d62d0d6c6c9c572b5871d0063c8b4fdf07 Mon Sep 17 00:00:00 2001
> > From: Meiyo Peng <address@hidden>
> > Date: Sun, 6 Jan 2019 22:11:36 +0800
> > Subject: [PATCH 1/3] gnu: fish: Update to 3.0.0.
> >
> > * gnu/packages/shells.scm (fish): Update to 3.0.0.
> >   [source]: Remove dead URL.
> >   [inputs]: Remove bc.  Replace python-wrapper with python.
> >   [arguments]: Remove configure-flags.  Enable fish to source
> >   /etc/fish/config.fish.  Enable completions, functions and configurations
> >   in user's and system's guix profiles.
>
> [...]
>
> >>From da8487fe9b9a0a0308f7b929f9e95e8e8297de26 Mon Sep 17 00:00:00 2001
> > From: Meiyo Peng <address@hidden>
> > Date: Sun, 20 Jan 2019 21:41:21 +0800
> > Subject: [PATCH 2/3] gnu: Add fish-foreign-env.
> >
> > * gnu/packages/shells.scm (fish-foreign-env): New variable.
>
> [...]
>
> >>From aadeb9dea8aff0db8a339cc11d006abff4736fdb Mon Sep 17 00:00:00 2001
> > From: Meiyo Peng <address@hidden>
> > Date: Sun, 20 Jan 2019 21:42:15 +0800
> > Subject: [PATCH 3/3] gnu: fish: Use fish-foreign-env to source /etc/profile.
> >
> > * gnu/packages/shells.scm (fish): Use fish-foreign-env to source /etc/profile
> >   when user logs in.
>
> Applied all three patches.  Thanks for working on it!
>
> Ludo’.
>
>
> --- End Message ---