emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[debbugs-tracker] bug#35141: closed (Add a default action to erc-desktop


From: GNU bug Tracking System
Subject: [debbugs-tracker] bug#35141: closed (Add a default action to erc-desktop-notifications to switch to the originating buffer)
Date: Fri, 12 Apr 2019 12:17:02 +0000

Your message dated Fri, 12 Apr 2019 13:16:41 +0100
with message-id <address@hidden>
and subject line Re: bug#35141: Add a default action to 
erc-desktop-notifications to switch to the originating buffer
has caused the debbugs.gnu.org bug report #35141,
regarding Add a default action to erc-desktop-notifications to switch to the 
originating buffer
to be marked as done.

(If you believe you have received this mail in error, please contact
address@hidden)


-- 
35141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35141
GNU Bug Tracking System
Contact address@hidden with problems
--- Begin Message --- Subject: Add a default action to erc-desktop-notifications to switch to the originating buffer Date: Thu, 4 Apr 2019 17:02:24 +1030
Attached is a patch which converts erc-desktop-notifications.el to lexical-binding and adds a default action to the generated notifications so that when they are clicked we automatically switch to the originating buffer.

Attachment: 0001-Switch-to-originating-erc-buffer-when-clicking-deskt.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#35141: Add a default action to erc-desktop-notifications to switch to the originating buffer Date: Fri, 12 Apr 2019 13:16:41 +0100 User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)
Alex Murray <address@hidden> writes:

> Done - see attached. Thanks again for your help.
>
> On Fri, 5 Apr 2019 at 21:52, Basil L. Contovounesios <address@hidden> wrote:
>
>  Otherwise LGTM, but we'll have to wait a few days to give others a
>  chance to comment.

Thanks, pushed to master[1].  I made minor edits to the commit message
to follow CONTRIBUTE guidelines and to make it slightly more accurate
and less redundant.

[1: 6dc4c722af]: Pop to originating erc buffer when clicking desktop 
notification
  2019-04-12 13:08:28 +0100
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=6dc4c722af4e5f9f189631638700cd1fb3cc2edb

If you're interested in making further contributions, I would recommend
starting the copyright assignment process.  See CONTRIBUTE and (info
"(emacs) Copyright Assignment") for details.

Thanks,

-- 
Basil


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]