bug#53418: closed ([PATCH] gnu: piper: Fix build.)

[GNU bug Tracking System]

Your message dated Fri, 21 Jan 2022 13:26:30 -0500
with message-id <Yer61kl9N9ZTDRHH@jasmine.lan>
and subject line Re: [bug#53418] [PATCH] gnu: piper: Fix build.
has caused the debbugs.gnu.org bug report #53418,
regarding [PATCH] gnu: piper: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
53418: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=53418
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: [PATCH] gnu: piper: Fix build. Date: Fri, 21 Jan 2022 18:17:57 +0000

Hello,

This is a followup to https://issues.guix.gnu.org/53372  fixing Piper (which 
uses libratbag). Python was added to the inputs to fix the build since Meson 
does not propagate Python (added to inputs rather than native-inputs as guix gc 
shows a reference to Python).

That allows Piper to build but it had a librsvg error on startup, like 
syncthing-gtk in https://issues.guix.gnu.org/52651  Fixed the same way here by 
removing librsvg from inputs since it is propagated by gtk+.

(Also simplified the input labels while I was at it, but my quick attempt at 
rewriting the phases with gexps didn't get far. Since I didn't find any similar 
examples in current packages, I left it as is for now.)

Thanks!
John

0001-gnu-piper-Fix-build.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#53418] [PATCH] gnu: piper: Fix build.
>
>
>
>
> Date: 
>
> Fri, 21 Jan 2022 13:26:30 -0500
>
>
>
>
> On Fri, Jan 21, 2022 at 06:17:57PM +0000, John Kehayias via Guix-patches via 
> wrote:
> > Hello,
> > 
> > This is a followup to https://issues.guix.gnu.org/53372  fixing Piper (which 
> > uses libratbag). Python was added to the inputs to fix the build since Meson 
> > does not propagate Python (added to inputs rather than native-inputs as guix 
> > gc shows a reference to Python).
> > 
> > That allows Piper to build but it had a librsvg error on startup, like 
> > syncthing-gtk in https://issues.guix.gnu.org/52651  Fixed the same way here 
> > by removing librsvg from inputs since it is propagated by gtk+.
> > 
> > (Also simplified the input labels while I was at it, but my quick attempt at 
> > rewriting the phases with gexps didn't get far. Since I didn't find any 
> > similar examples in current packages, I left it as is for now.)
> > 
> > Thanks!
> > John
>
> > From 5ae7945017dc4d664bdc6ddbffaea6422db72402 Mon Sep 17 00:00:00 2001
> > From: John Kehayias <john.kehayias@protonmail.com>
> > Date: Fri, 21 Jan 2022 13:05:15 -0500
> > Subject: [PATCH] gnu: piper: Fix build.
> > 
> > Since commit 6f36d0c89e3bf19bb7bb8f7f5b77de30c9af861b, Meson no longer
> > propagates Python.  GTK+ propagates librsvg-bootstrap which causes a startup
> > error due to two librsvg being GI_TYPELIB_PATH.
> > 
> > * gnu/packages/gnome.scm (piper)[inputs]: Add PYTHON.  Remove LIBRSVG.  
> > Simplify.
> > [native-inputs]: Simplify.
> > [arguments]: Remove trailing #t from phases.
>
> Thanks! Pushed as 0baf5efe01d613f82edca39b47ef2126803127a4
>
>
> --- End Message ---