bug#52891: closed ([PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.)

[GNU bug Tracking System]

Your message dated Tue, 08 Nov 2022 10:58:54 +0100
with message-id <87leol7oo1.fsf_-_@gnu.org>
and subject line Re: bug#52891: [PATCH] guix-install.sh: Run guix.sh script in 
/etc/profile.d last.
has caused the debbugs.gnu.org bug report #52891,
regarding [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
52891: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=52891
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
>
>
>
>
> Date: 
>
> Thu, 30 Dec 2021 09:39:31 +0100
>
>
>
>
> * etc/guix-install.sh: Rename /etc/profile.d/guix.sh to zzz-guix.sh.
>
> This script refers to environment variables set by the host distribution.
> They may be set in other scripts in /etc/profile.d, which must therefore
> be run first.
> Example: in Ubuntu 20.04, XDG_DATA_DIRS is set in
> /etc/profile.d/xdg_dirs_desktop_session.sh
> ---
>  etc/guix-install.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/guix-install.sh b/etc/guix-install.sh
> index cd1a1c34c1..00a9fc5377 100755
> --- a/etc/guix-install.sh
> +++ b/etc/guix-install.sh
> @@ -503,7 +503,7 @@ sys_create_init_profile()
>  { # Define for better desktop integration
>    # This will not take effect until the next shell or desktop session!
>      [ -d "/etc/profile.d" ] || mkdir /etc/profile.d # Just in case
> -    cat <<"EOF" > /etc/profile.d/guix.sh
> +    cat <<"EOF" > /etc/profile.d/zzz-guix.sh
>  # _GUIX_PROFILE: `guix pull` profile
>  _GUIX_PROFILE="$HOME/.config/guix/current"
>  export PATH="$_GUIX_PROFILE/bin${PATH:+:}$PATH"
> -- 
> 2.34.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#52891: [PATCH] guix-install.sh: Run guix.sh script in /etc/profile.d last.
>
>
>
>
> Date: 
>
> Tue, 08 Nov 2022 10:58:54 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> > Does anybody have objections, such as distros where this would not work?
> >
> > Otherwise let’s apply it in time for the upcoming release.
>
> Tested on Ubuntu, seems to work fine. It appears to be the right thing
> to do to make sure that Guix stuff is prepended to XDG_*, PATH and
> INFOPATH variables.
>
> Applied as 93be56a3ab28ed0a482f354b7f536681c99b6999.
>
> Thanks,
>
> Mathieu
>
>
> --- End Message ---