[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#58883: closed (CC Mode 5.35.1 (C/*l); Incorrect fontification of X f
|
From: |
GNU bug Tracking System |
|
Subject: |
bug#58883: closed (CC Mode 5.35.1 (C/*l); Incorrect fontification of X function) |
|
Date: |
Tue, 08 Nov 2022 12:22:02 +0000 |
Your message dated Tue, 8 Nov 2022 12:21:02 +0000
with message-id <Y2pJrocD2j+pICqQ@ACM>
and subject line Re: bug#58883
has caused the debbugs.gnu.org bug report #58883,
regarding CC Mode 5.35.1 (C/*l); Incorrect fontification of X function
to be marked as done.
(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)
--
58883: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58883
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message ---
|
Subject: |
CC Mode 5.35.1 (C/*l); Incorrect fontification of X function |
|
Date: |
Sun, 30 Oct 2022 09:22:45 +0800 |
Package: cc-mode
In the following Xlib function:
Bool XCheckIfEvent (
register Display *dpy,
register XEvent *event, /* XEvent to be filled in. */
Bool (*predicate)(
Display* /* display */,
XEvent* /* event */,
char* /* arg */
), /* function to call */
char *arg)
{
register _XQEvent *prev, *qelt;
unsigned long qe_serial = 0;
int n; /* time through count */
LockDisplay(dpy);
prev = NULL;
for (n = 3; --n >= 0;) {
for (qelt = prev ? prev->next : dpy->head;
qelt;
prev = qelt, qelt = qelt->next) {
if(qelt->qserial_num > qe_serial
&& (*predicate)(dpy, &qelt->event, arg)) {
*event = qelt->event;
_XDeq(dpy, prev, qelt);
_XStoreEventCookie(dpy, event);
UnlockDisplay(dpy);
return True;
}
}
if (prev)
qe_serial = prev->qserial_num;
switch (n) {
case 2:
_XEventsQueued(dpy, QueuedAfterReading);
break;
case 1:
_XFlush(dpy);
break;
}
if (prev && prev->qserial_num != qe_serial)
/* another thread has snatched this event */
prev = NULL;
}
UnlockDisplay(dpy);
return False;
}
Bool XCheckIfEvent (
register Display *dpy,
register XEvent *event, /* XEvent to be filled in. */
Bool (*predicate)(
Display* /* display */,
XEvent* /* event */,
char* /* arg */
), /* function to call */
char *arg)
{
register _XQEvent *prev, *qelt;
unsigned long qe_serial = 0;
int n; /* time through count */
LockDisplay(dpy);
prev = NULL;
for (n = 3; --n >= 0;) {
for (qelt = prev ? prev->next : dpy->head;
qelt;
prev = qelt, qelt = qelt->next) {
if(qelt->qserial_num > qe_serial
&& (*predicate)(dpy, &qelt->event, arg)) {
*event = qelt->event;
_XDeq(dpy, prev, qelt);
_XStoreEventCookie(dpy, event);
UnlockDisplay(dpy);
return True;
}
}
if (prev)
qe_serial = prev->qserial_num;
switch (n) {
case 2:
_XEventsQueued(dpy, QueuedAfterReading);
break;
case 1:
_XFlush(dpy);
break;
}
if (prev && prev->qserial_num != qe_serial)
/* another thread has snatched this event */
prev = NULL;
}
UnlockDisplay(dpy);
return False;
}
"Display" and "XEvent" are not fontified as types, inside both the
function prototype and that of the predcate argument.
"_XQEvent" also fails to be fontified as a type.
Emacs : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
of 2022-10-29
Package: CC Mode 5.35.1 (C/*l)
Buffer Style: gnu
c-emacs-features: (pps-extended-state col-0-paren posix-char-classes
gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)
current state:
==============
(setq
c-basic-offset 2
c-comment-only-line-offset '(0 . 0)
c-indent-comment-alist '((anchored-comment column . 0) (end-block space . 1)
(cpp-end-block space . 2))
c-indent-comments-syntactically-p nil
c-block-comment-prefix ""
c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+")
(other . "//+\\|\\**"))
c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode .
gtkdoc) (c++-mode . gtkdoc))
c-cleanup-list '(scope-operator)
c-hanging-braces-alist '((substatement-open before after)
(arglist-cont-nonempty))
c-hanging-colons-alist nil
c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist)
c-backslash-column 48
c-backslash-max-column 72
c-special-indent-hook '(t c-gnu-impose-minimum)
c-label-minimum-indentation 1
c-offsets-alist '((inexpr-class . +)
(inexpr-statement . +)
(lambda-intro-cont . +)
(inlambda . 0)
(template-args-cont c-lineup-template-args +)
(incomposition . +)
(inmodule . +)
(innamespace . +)
(inextern-lang . +)
(composition-close . 0)
(module-close . 0)
(namespace-close . 0)
(extern-lang-close . 0)
(composition-open . 0)
(module-open . 0)
(namespace-open . 0)
(extern-lang-open . 0)
(objc-method-call-cont c-lineup-ObjC-method-call-colons
c-lineup-ObjC-method-call +)
(objc-method-args-cont . c-lineup-ObjC-method-args)
(objc-method-intro . [0])
(friend . 0)
(cpp-define-intro c-lineup-cpp-define +)
(cpp-macro-cont . +)
(cpp-macro . [0])
(inclass . +)
(stream-op . c-lineup-streamop)
(arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist)
(arglist-cont c-lineup-gcc-asm-reg 0)
(comment-intro c-lineup-knr-region-comment c-lineup-comment)
(catch-clause . 0)
(else-clause . 0)
(do-while-closure . 0)
(access-label . -)
(case-label . 0)
(substatement . +)
(statement-case-intro . +)
(statement . 0)
(brace-entry-open . 0)
(brace-list-entry . 0)
(brace-list-close . 0)
(block-close . 0)
(block-open . 0)
(inher-cont . c-lineup-multi-inher)
(inher-intro . +)
(member-init-cont . c-lineup-multi-inher)
(member-init-intro . +)
(annotation-var-cont . +)
(annotation-top-cont . 0)
(topmost-intro . 0)
(knr-argdecl . 0)
(func-decl-cont . +)
(inline-close . 0)
(class-close . 0)
(class-open . 0)
(defun-block-intro . +)
(defun-close . 0)
(defun-open . 0)
(c . c-lineup-C-comments)
(string . c-lineup-dont-change)
(topmost-intro-cont first c-lineup-topmost-intro-cont
c-lineup-gnu-DEFUN-intro-cont)
(brace-list-intro first c-lineup-2nd-brace-entry-in-arglist
c-lineup-class-decl-init-+ +)
(brace-list-open . +)
(inline-open . 0)
(arglist-close . c-lineup-arglist)
(arglist-intro . c-lineup-arglist-intro-after-paren)
(statement-cont . +)
(statement-case-open . +)
(label . 0)
(substatement-label . 0)
(substatement-open . +)
(knr-argdecl-intro . 5)
(statement-block-intro . +)
)
c-buffer-is-cc-mode 'c-mode
c-tab-always-indent t
c-syntactic-indentation t
c-syntactic-indentation-in-macros t
c-ignore-auto-fill '(string cpp code)
c-auto-align-backslashes t
c-backspace-function 'backward-delete-char-untabify
c-delete-function 'delete-char
c-electric-pound-behavior nil
c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu"))
c-enable-xemacs-performance-kludge-p nil
c-old-style-variable-behavior nil
defun-prompt-regexp nil
tab-width 8
comment-column 32
parse-sexp-ignore-comments t
parse-sexp-lookup-properties t
auto-fill-function nil
comment-multi-line t
comment-start-skip "\\(?://+\\|/\\*+\\)\\s *"
fill-prefix nil
fill-column 70
paragraph-start "[ ]*\\(//+\\|\\**\\)[ ]*$\\|^\f"
adaptive-fill-mode t
adaptive-fill-regexp "[ ]*\\(//+\\|\\**\\)[ ]*\\([
]*\\([-–!|#%;>*·•‣⁃◦]+[ ]*\\)*\\)"
)
--- End Message ---
--- Begin Message ---
|
Subject: |
Re: bug#58883 |
|
Date: |
Tue, 8 Nov 2022 12:21:02 +0000 |
Hello, Po.
On Tue, Nov 08, 2022 at 18:02:12 +0800, Po Lu wrote:
> Alan Mackenzie <acm@muc.de> writes:
> > Hello, Po.
> > On Tue, Nov 08, 2022 at 08:25:31 +0800, Po Lu wrote:
> >> Alan Mackenzie <acm@muc.de> writes:
> > [ .... ]
> >> > I have a fix for this, I think, but it overlaps with an earlier fix to
> >> > bug #58883. I sent you a patch on Sunday 2022-10-30 for this earlier
> >> > bug. Did you get this patch? If so, have you any reaction to it?
> >> I think it got lost in the bulk mail folder (but I can't find it there
> >> either, so maybe a mailer screwup?)
> >> So would you please send it again? TIA.
> > OK, here it is!
> > Thanks!
> > [ I've set the Subject: to bug#58883, and the Cc: to
> > 58883@debbugs.gnu.org. ]
> That seems to solve this problem (bug#58883) for me.
Excellent! I've committed the patch, and I'm closing the bug with this
post.
> However, I'm beginning to see a general pattern here. When the mistaken
> type classification is corrected, bad fortification above the last edit
> is not removed. Shouldn't that be fixed also?
I'm gradually fixing it.
The mechanism is that when C Mode sees what it takes to be a type, from
the context, c-forward-type returns the symbol 'maybe.
Later on in the processing, the analysis of the C code "confirms" that
this 'maybe actually is a type, and it gets promoted to 'found, and
entered into the c-found-types list. At the same time, other occurrences
of the type throughout the buffer are fontified as types.
This mechanism is not foolproof, and goes wrong when a statement is
partially typed. Rather than correcting the mistakenly fontified
"types", which would be more difficult, I'm concentrating on not
promoting a 'maybe type to a 'found type too enthusiasically.
The problem here is that CC Mode isn't a compiler, and doesn't do very
deep analysis on the source. The new mode with tree sitter will likely
do much better on such troublesome sources in the future. Sorry!
> Thanks.
--
Alan Mackenzie (Nuremberg, Germany).
--- End Message ---
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#58883: closed (CC Mode 5.35.1 (C/*l); Incorrect fontification of X function),
GNU bug Tracking System <=