bug#63117: closed ([PATCH] gnu: yt-dlp: Change input.)

[GNU bug Tracking System]

Your message dated Thu, 25 May 2023 12:42:25 +0200
with message-id <87ilcgg0a6.fsf_-_@gnu.org>
and subject line Re: bug#63117: [PATCH] gnu: yt-dlp: Change input.
has caused the debbugs.gnu.org bug report #63117,
regarding [PATCH] gnu: yt-dlp: Change input.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63117: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63117
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: yt-dlp: Change input.
>
>
>
>
> Date: 
>
> Thu, 27 Apr 2023 16:32:00 +0200
>
>
>
>
> yt-dlp complained when the "--add-metadata" flag was used.
> youtube-dl does not need ffmpeg as a propagated-input, though.
>
> * gnu/packages/video.scm (yt-dlp)[inputs]: Remove ffmpeg.
> [propagated-inputs]: Add ffmpeg.
> ---
>  gnu/packages/video.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index 838dfe7..df6bbc5 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -2598,6 +2598,7 @@ (define-public yt-dlp
>                  (when tests?
>                    (invoke "pytest" "-k" "not download"))))))))
>      (inputs (modify-inputs (package-inputs youtube-dl)
> +              (delete ffmpeg) ;yt-dlp needs it as propagated-input
>                (append python-brotli
>                        python-certifi
>                        python-mutagen
> @@ -2611,6 +2612,8 @@ (define-public yt-dlp
>           (list pandoc)
>           '())
>         (list python-pytest zip)))
> +    (propagated-inputs
> +     (list ffmpeg))
>      (description
>       "yt-dlp is a small command-line program to download videos from
>  YouTube.com and many more sites.  It is a fork of youtube-dl with a
>
> base-commit: fa685c87eaa9888a4278f39bb2b815673589dced
> -- 
> 2.39.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#63117: [PATCH] gnu: yt-dlp: Change input.
>
>
>
>
> Date: 
>
> Thu, 25 May 2023 12:42:25 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hi Dominik,
>
> Dominik Delgado Steuter <dds@disroot.org> skribis:
>
> > The old expression did not work; ffmpeg was not found
> > when using the --add-metadata flag.
> >
> > * gnu/packages/video.scm (yt-dlp)
> > [arguments]: Adjust substitution in custom 'default-to-the-ffmpeg-input phase.
>
> Applied.  Thank you and thanks to Liliana for reviewing!
>
> Ludo’.
>
>
> --- End Message ---