bug#63798: closed ([PATCH] Fix Erlang package substitutions)

[GNU bug Tracking System]

Your message dated Sat, 01 Jul 2023 12:07:18 +0200
with message-id <875y74kkrt.fsf@nicolasgoaziou.fr>
and subject line Re: [bug#63798] [PATCH] Fix Erlang package substitutions
has caused the debbugs.gnu.org bug report #63798,
regarding [PATCH] Fix Erlang package substitutions
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63798: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63798
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Fix Erlang package substitutions
>
>
>
>
> Date: 
>
> Mon, 29 May 2023 23:22:24 +0100
>
>
>
>
> Both `dirname` and `basename` need to be substituted. There is no need
> for `sed` substitution in Erlag 25.3.
> ---
>  gnu/packages/erlang.scm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index 7564c2a560..b6e82e0109 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -8,6 +8,7 @@
>  ;;; Copyright © 2021 Oskar Köök <oskar@maatriks.ee>
>  ;;; Copyright © 2021 Cees de Groot <cg@evrl.com>
>  ;;; Copyright © 2022 jgart <jgart@dismail.de>
> +;;; Copyright © 2023 wrobell <wrobell@riseup.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -168,7 +169,8 @@ (define-public erlang
>             (lambda* (#:key outputs #:allow-other-keys)
>               (let ((out (assoc-ref outputs "out")))
>                 (substitute* (string-append out "/bin/erl")
> -                 (("sed") (which "sed"))))))
> +                 (("basename") (which "basename"))
> +                 (("dirname") (which "dirname"))))))
>           (add-after 'install 'install-doc
>             (lambda* (#:key inputs outputs #:allow-other-keys)
>               (let* ((out (assoc-ref outputs "out"))
>
> base-commit: 7b400e7f8751e6b0cc6e66d3f7ecfb7f5bd51309
> -- 
> 2.40.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#63798] [PATCH] Fix Erlang package substitutions
>
>
>
>
> Date: 
>
> Sat, 01 Jul 2023 12:07:18 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
>
>
>
>
> Hello,
>
> wrobell <wrobell@riseup.net> writes:
>
> > Both `dirname` and `basename` need to be substituted. There is no need
> > for `sed` substitution in Erlag 25.3.
>
> Applied, with a proper commit message. Thank you.
>
> Regards,
> -- 
> Nicolas Goaziou
>
>
> --- End Message ---