emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#64266: closed ([PATCH] ; * lisp/progmodes/project.el (project-curren


From: GNU bug Tracking System
Subject: bug#64266: closed ([PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix.)
Date: Thu, 13 Jul 2023 06:16:01 +0000

Your message dated Thu, 13 Jul 2023 09:15:51 +0300
with message-id <83bkgg5obs.fsf@gnu.org>
and subject line Re: bug#64266: [PATCH] ; * lisp/progmodes/project.el 
(project-current): Doc fix.
has caused the debbugs.gnu.org bug report #64266,
regarding [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
64266: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64266
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix. Date: Sat, 24 Jun 2023 17:35:12 +0300
Tags: patch

Hi,

Since commit 9efa6d2cf28f4e21f23bb0dbfedc59a4286dab12, the function
`project-current` uses the function specified by `project-prompter`
rather than calling `project-prompt-project-dir` directly.  As a result,
it can prompt for a project by its name rather than by its root
directory (depending on the value of `project-prompter`), but the doc
string of `project-current` says that it "asks the user for a directory"
without mentioning `project-prompter`.  This patch clarifies that
`project-current` uses `project-prompter` for prompting.


In GNU Emacs 30.0.50 (build 18, x86_64-apple-darwin22.5.0, NS
 appkit-2299.60 Version 13.4 (Build 22F66)) of 2023-06-24 built on
 Dazzs-MBP
Repository revision: 77c2f05d773271cb59ebfd994b06a4075cacbfa8
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.4

Configured using:
 'configure 'CFLAGS=-g0 -O3' --with-native-compilation --with-json
 --with-imagemagick --with-tree-sitter --enable-link-time-optimization'

Attachment: 0001-lisp-progmodes-project.el-project-current-Doc-fix.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#64266: [PATCH] ; * lisp/progmodes/project.el (project-current): Doc fix. Date: Thu, 13 Jul 2023 09:15:51 +0300
> From: Eshel Yaron <me@eshelyaron.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  64266@debbugs.gnu.org, sbaugh@catern.com
> Date: Sun, 09 Jul 2023 10:57:13 +0300
> 
> Dmitry Gutov <dmitry@gutov.dev> writes:
> 
> > On 24/06/2023 20:06, Eli Zaretskii wrote:
> >> I would recommend waiting for Dmitry and Spencer to chime in, and
> >> submit a followup after their comments, if any.
> >
> > Your suggested versions sounds good to me too, thanks.
> 
> Thanks, I'm attaching an updated patch following Eli's wording.
> 
> Also CC'ing Spencer in case there are further comments.

Thanks, installed on the master branch, and closing the bug.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]