emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#61661: closed (30.0.50; [PATCH] Define 'appt-notification' face)


From: GNU bug Tracking System
Subject: bug#61661: closed (30.0.50; [PATCH] Define 'appt-notification' face)
Date: Mon, 04 Sep 2023 20:52:02 +0000

Your message dated Mon, 4 Sep 2023 13:51:44 -0700
with message-id 
<CADwFkmnezJ4UHQqdrGXUjduGNeV5iXXcWRrxG9O=HDhMhn-Mmw@mail.gmail.com>
and subject line Re: bug#61661: 30.0.50; [PATCH] Define 'appt-notification' face
has caused the debbugs.gnu.org bug report #61661,
regarding 30.0.50; [PATCH] Define 'appt-notification' face
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
61661: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61661
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: 30.0.50; [PATCH] Define 'appt-notification' face Date: Mon, 20 Feb 2023 21:15:12 +0200
Dear maintainers,

The appt.el library can show a notification for upcoming appointments on
the mode line.  The face it uses is hardcoded to 'mode-line-emphasis'
which, by default, is a bold weight.

With the attached patch, we have a new face that the user/theme can set
to something easier to spot like bold+red.  Decoupling this indicator
from the generic 'mode-line-emphasis' allows us to add extra styling
only to the notification without affecting other parts of the mode line
that may be using 'mode-line-emphasis'.

What do you think?

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

Attachment: 0001-Add-appt-notification-face.patch
Description: Text Data


--- End Message ---
--- Begin Message --- Subject: Re: bug#61661: 30.0.50; [PATCH] Define 'appt-notification' face Date: Mon, 4 Sep 2023 13:51:44 -0700
Protesilaos Stavrou <info@protesilaos.com> writes:

> The appt.el library can show a notification for upcoming appointments on
> the mode line.  The face it uses is hardcoded to 'mode-line-emphasis'
> which, by default, is a bold weight.
>
> With the attached patch, we have a new face that the user/theme can set
> to something easier to spot like bold+red.  Decoupling this indicator
> from the generic 'mode-line-emphasis' allows us to add extra styling
> only to the notification without affecting other parts of the mode line
> that may be using 'mode-line-emphasis'.
>
> What do you think?

Makes sense to me.  I edited your NEWS message to be more clear, and
installed this on master as commit 367c3f25a16.


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]