bug#59458: closed ([PATCH] Fix tracing for advanced scoring)

[GNU bug Tracking System]

Your message dated Mon, 11 Sep 2023 17:32:20 -0700
with message-id 
<CADwFkmkd-YYZi+haPN0PEWVdCZXpvfV7YJyQVxtKK9Lv_9LPbA@mail.gmail.com>
and subject line Re: bug#59458: [PATCH] Fix tracing for advanced scoring
has caused the debbugs.gnu.org bug report #59458,
regarding [PATCH] Fix tracing for advanced scoring
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
59458: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59458
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] Fix tracing for advanced scoring
>
>
>
>
> Date: 
>
> Mon, 21 Nov 2022 22:30:55 +0100
>
>
>
>
> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing
> code outside of if so it's executed for both branches.
> ---
>  lisp/gnus/gnus-logic.el | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/gnus/gnus-logic.el b/lisp/gnus/gnus-logic.el
> index c1b559ba6f4..346d8a28910 100644
> --- a/lisp/gnus/gnus-logic.el
> +++ b/lisp/gnus/gnus-logic.el
> @@ -71,11 +71,11 @@
>                     (+ (cdr score) new-score))
>           (push (cons (mail-header-number gnus-advanced-headers)
>                       new-score)
> -               gnus-newsgroup-scored)
> -         (when trace
> -           (push (cons "A file" rule)
> -                 ;; Must be synced with `gnus-score-edit-file-at-point'.
> -                 gnus-score-trace)))))))
> +               gnus-newsgroup-scored))
> +       (when trace
> +         (push (cons "A file" rule)
> +               ;; Must be synced with `gnus-score-edit-file-at-point'.
> +               gnus-score-trace))))))
>  
>  (defun gnus-advanced-score-rule (rule)
>    "Apply RULE to `gnus-advanced-headers'."
> -- 
> 2.30.2
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#59458: [PATCH] Fix tracing for advanced scoring
>
>
>
>
> Date: 
>
> Mon, 11 Sep 2023 17:32:20 -0700
>
>
>
>
> Version: 30.1
>
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
> > On 09/07/23 14:07 PM, Stefan Kangas wrote:
> >
> >> Eric,
> >>
> >> It would be great if you could help review this.  Thanks in advance.
> >
> > I've taken a closer look, and I do think this is okay. The `when' after
> > the `dolist' only fires if the rule matches, the `if' is only there to
> > see if this article has been previously scored or not. So moving the
> > "(when trace" up to the top-level of the containing `when' (ie, out of the
> > `if') does look like the right thing to do.
>
> Thanks.  Installed it on master as commit e25ad6e2a30.
>
>
> --- End Message ---