bug#49181: closed (Fix missing phases in Emacs builds)

[GNU bug Tracking System]

Your message dated Mon, 09 Oct 2023 23:37:30 -0400
with message-id <87h6mz6tc5.fsf_-_@gmail.com>
and subject line Re: bug#49181: [PATCH core-updates v2] guix: Make 
modify-phases error when adding before/after a missing phase
has caused the debbugs.gnu.org bug report #49181,
regarding Fix missing phases in Emacs builds
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
49181: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=49181
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems

--- Begin Message --- Subject: Fix missing phases in Emacs builds Date: Wed, 23 Jun 2021 16:45:28 +1000 User-agent: mu4e 1.4.15; emacs 27.2

Hi there!

I went to install emacs-protobuf-mode today and found that the build wasn't working. I investigated and it looks like someone renamed the add-source-to-load-path phase to expand-load-path, but they left a few references behind. The first of my patches fixes that.

The second of my patches is more controversial. It changes modify-phases to error out if the asked-for phase doesn't exist in add-before/add-after clauses. I think this is the right move, because it's hard to imagine when the default behaviour of "add to the end of the phases list" is helpful. In most cases the extra phases are setup/transformation phases that we need to run before the final "install" phase, so it's far more useful to fail early than to add these to the end of the phases list.

Carlo

0001-gnu-Fix-references-to-emacs-build-system-s-expand-lo.patch
Description: Text Data

0002-guix-Make-modify-phases-error-when-adding-before-aft.patch
Description: Text Data

--- End Message ---

> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#49181: [PATCH core-updates v2] guix: Make modify-phases error when adding before/after a missing phase
>
>
>
>
> Date: 
>
> Mon, 09 Oct 2023 23:37:30 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Carlo Zancanaro <carlo@zancanaro.id.au> writes:
>
> > * guix/build/utils.scm (alist-cons-before, alist-cons-after): Cause a match 
> > failure if the
> > reference is not found, rather than appending to the alist.
> > * tests/build-utils.scm: Update tests to match.
>
> Installed to core-updates!
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---