bug#63854: closed ([PATCH] gnu: po4a: Fix SGML tests.)

[GNU bug Tracking System]

Your message dated Tue, 10 Oct 2023 21:52:03 -0400
with message-id <87v8bediyk.fsf@gmail.com>
and subject line Re: [bug#63854] [PATCH v5] gnu: po4a: Enable SGML format.
has caused the debbugs.gnu.org bug report #63854,
regarding [PATCH] gnu: po4a: Fix SGML tests.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
63854: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63854
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH] gnu: po4a: Fix SGML tests.
>
>
>
>
> Date: 
>
> Sat,  3 Jun 2023 02:52:56 +0900
>
>
>
>
> * gnu/packages/gettext.scm (po4a): Fix SGML tests.
> ---
>  gnu/packages/gettext.scm | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/gettext.scm b/gnu/packages/gettext.scm
> index 9387f4fb8a5..0d66d492d40 100644
> --- a/gnu/packages/gettext.scm
> +++ b/gnu/packages/gettext.scm
> @@ -11,7 +11,7 @@
>  ;;; Copyright © 2019 Miguel <rosen644835@gmail.com>
>  ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
>  ;;; Copyright © 2020 EuAndreh <eu@euandre.org>
> -;;; Copyright © 2022 gemmaro <gemmaro.dev@gmail.com>
> +;;; Copyright © 2022, 2023 gemmaro <gemmaro.dev@gmail.com>
>  ;;; Copyright © 2023 Maxim Cournoyer maxim.cournoyer@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
> @@ -280,10 +280,11 @@ (define-public po4a
>                              (wrap-program file
>                                `("PERL5LIB" ":" prefix (,path))))
>                            (find-files bin "\\.*$")))))
> -          (add-before 'check 'disable-failing-tests
> -            (lambda _
> -              ;; FIXME: fails despite of importing SGMLS
> -              (delete-file "t/fmt-sgml.t"))))))
> +          (add-before 'check 'set-SGML-catalog-file
> +            (lambda* (#:key inputs #:allow-other-keys)
> +              (setenv "SGML_CATALOG_FILES"
> +                      (string-append (assoc-ref inputs "docbook-sgml")
> +                                     "/sgml/dtd/docbook/docbook.cat")))))))
>      (native-inputs
>       (list gettext-minimal
>             perl-module-build
> @@ -291,11 +292,13 @@ (define-public po4a
>             libxml2
>             libxslt
>             ;; For tests.
> +           docbook-sgml-4.1
>             docbook-xml-4.1.2
>             perl-test-pod
>             texlive-tiny))
>      (inputs
>       (list bash-minimal
> +           opensp
>             perl-gettext
>             perl-pod-parser
>             perl-sgmls
>
> base-commit: a7d9cd742c3149bb014db95f88d1158d590bc124
> -- 
> 2.40.1
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#63854] [PATCH v5] gnu: po4a: Enable SGML format.
>
>
>
>
> Date: 
>
> Tue, 10 Oct 2023 21:52:03 -0400
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Bruno Victal <mirai@makinata.eu> writes:
>
> > From: gemmaro <gemmaro.dev@gmail.com>
> >
> > * gnu/packages/gettext.scm (po4a): Enable SGML format.
> > [arguments]<phases>: Remove disable-failing-tests phase.
> > [native-inputs]: Add docbook-sgml-4.1. Remove libxml2.
> > [inputs]: Add opensp.
>
> Installed to core-updates; thanks!
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---