emacs-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#66616: closed ([PATCH v2] etc: gitconfig: Run etc/teams.scm from cor


From: GNU bug Tracking System
Subject: bug#66616: closed ([PATCH v2] etc: gitconfig: Run etc/teams.scm from correct environment.)
Date: Mon, 23 Oct 2023 00:41:02 +0000

Your message dated Sun, 22 Oct 2023 20:39:37 -0400
with message-id <87edhmb29i.fsf@gmail.com>
and subject line Re: [bug#66605] [PATCH v5] teams: Adjust shebang to use 'guix 
repl'.
has caused the debbugs.gnu.org bug report #66605,
regarding [PATCH v2] etc: gitconfig: Run etc/teams.scm from correct environment.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66605: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66605
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
--- Begin Message --- Subject: [PATCH v2] etc: gitconfig: Run etc/teams.scm from correct environment. Date: Wed, 18 Oct 2023 23:10:24 +0200
* etc/git/gitconfig: Prepend "guix repl" to the etc/teams.scm script so that
any user that has git:send-email installed can use it in the Guix checkout
without changing their environment.  (teams.scm uses (git) and (guix ui).)
---
Actually I had forgotten about `guix repl`.  Maybe this patch is better?

Clément

 etc/git/gitconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/git/gitconfig b/etc/git/gitconfig
index 907ad0180454..abcd494d62e8 100644
--- a/etc/git/gitconfig
+++ b/etc/git/gitconfig
@@ -14,5 +14,5 @@
 
 [sendemail]
         to = guix-patches@gnu.org
-        headerCmd = etc/teams.scm cc-members-header-cmd
+        headerCmd = guix repl etc/teams.scm cc-members-header-cmd
         thread = no

base-commit: 5498835bb38c0de57f284f0fa6b1178ecdcaf678
prerequisite-patch-id: d95e49e4fc059972fc5a7b2c92816df2228a0af1
prerequisite-patch-id: a0dca8c3175d6ce71c77e220c4ac98b6e97cef56
-- 
2.41.0




--- End Message ---
--- Begin Message --- Subject: Re: [bug#66605] [PATCH v5] teams: Adjust shebang to use 'guix repl'. Date: Sun, 22 Oct 2023 20:39:37 -0400 User-agent: Gnus/5.13 (Gnus v5.13)
Hi,

Clément Lassieur <clement@lassieur.org> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> This ensures the correct Guix dependencies are always available for the
>> script.
>>
>> * etc/teams.scm.in: Rename to...
>> * etc/teams.scm: ... this.  Adjust shebang.
>> * .gitignore: No longer ignore it.
>> * configure.ac: Do not process it with AC_CONFIG_FILES.
>>
>> Fixes: https://issues.guix.gnu.org/66605
>> ---
>
> Sounds good to me!  Of course, please commit it as your own.
>
> Thank you very much,
> Clément

Done!  Thanks for the report!

-- 
Thanks,
Maxim


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]