bug#66475: closed ([PATCH 0/2] Add support for Git Large File Storage (LFS).)

[GNU bug Tracking System]

Your message dated Tue, 07 Nov 2023 11:17:50 -0500
with message-id <87a5rpk05t.fsf@gmail.com>
and subject line Re: [bug#66475] [PATCH v2 1/4] git-download: Add support for 
Git Large File Storage (LFS).
has caused the debbugs.gnu.org bug report #66475,
regarding [PATCH 0/2] Add support for Git Large File Storage (LFS).
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
66475: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66475
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] Add support for Git Large File Storage (LFS).
>
>
>
>
> Date: 
>
> Wed, 11 Oct 2023 22:49:33 -0400
>
>
>
>
> While updating orcus to its latest version (0.19.0), I stumbled on a test a
> failure, which ended up being caused by the lack of test files in the
> repository checkout.  These files are stored using the LFS extension in the
> repo; when not using LFS, empty text stubs with some metadata are left in
> their place.
>
> I've opted to keep the dependency on git-lfs optional for now for the daemon.
> The git in-band downloader will only add the git-lfs dependency when the
> git-reference object has its lfs? field set to true.
>
> Maxim Cournoyer (2):
>   gnu: git-lfs: Patch /bin/sh references.
>   git-download: Add support for Git Large File Storage (LFS).
>
>  configure.ac                      | 10 ++++++
>  doc/guix.texi                     |  9 +++++
>  gnu/packages/version-control.scm  |  5 +++
>  guix/build/git.scm                | 18 +++++++---
>  guix/config.scm.in                |  4 +++
>  guix/git-download.scm             | 58 ++++++++++++++++++++-----------
>  guix/scripts/perform-download.scm |  3 ++
>  guix/self.scm                     | 10 +++++-
>  8 files changed, 92 insertions(+), 25 deletions(-)
>
>
> base-commit: d6d706a58b8159748d3a46fa97cae18850487c8a
> --
> 2.41.0
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#66475] [PATCH v2 1/4] git-download: Add support for Git Large File Storage (LFS).
>
>
>
>
> Date: 
>
> Tue, 07 Nov 2023 11:17:50 -0500
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hi,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
> > Hi Maxim,
> >
> > Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
> >
> >> * guix/build/git.scm (git-fetch) [lfs?]: New argument, doc and setup code.
> >> (git-fetch-with-fallback) [lfs?]: New argument.  Pass it to git-fetch.
> >> * guix/git-download.scm (git-lfs-package): New procedure.
> >> (git-fetch/in-band*): New procedure, made of the logic of git-fetch/in-band,
> >> with new git-lfs specifics, with the following changes:
> >> New #:git-lfs argument.
> >> <inputs>: Remove labels.  Conditionally add git-lfs.
> >> <build>: Read "git lfs?" environment
> >> variable and pass its value to the #:lfs? argument of 
> >> git-fetch-with-fallback.
> >> Use INPUTS directly; update comment.
> >> <gexp->derivation>: Add "git lfs?" to #:env-vars.
> >> (git-fetch/in-band): Express in terms of git-fetch/in-band*.
> >> (git-fetch/lfs): New procedure.
> >> * doc/guix.texi (origin Reference): Document it.
> >>
> >> Change-Id: I5b233b8642a7bdb8737b9d9b740e7254a89ccb25
> >> ---
> >>
> >> Changes in v2:
> >>  - Do not add lfs? to <git-reference>; instead add a git-fetch/lfs procedure.
> >
> > I haven’t tested it but it looks great to me, thank you!
>
> Thanks for taking the time to review it!  I'll push it shortly.
>
> -- 
> Thanks,
> Maxim
>
>
> --- End Message ---