bug#68263: closed ([PATCH 0/2] libsmbios: Restrict to only supported systems.)

[GNU bug Tracking System]

Your message dated Fri, 12 Jan 2024 17:03:23 +0100
with message-id <87ply6r12s.fsf@gnu.org>
and subject line Re: [bug#68263] [PATCH v2 0/2] libsmbios: Restrict to only 
supported systems.
has caused the debbugs.gnu.org bug report #68263,
regarding [PATCH 0/2] libsmbios: Restrict to only supported systems.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
68263: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68263
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> [PATCH 0/2] libsmbios: Restrict to only supported systems.
>
>
>
>
> Date: 
>
> Fri,  5 Jan 2024 09:45:49 -0500
>
>
>
>
> Here are a couple patches that fix build failures of libsmbios, a library for
> accessing System Management BIOS[0] data, by restricting its package to only
> platforms the library supports (Linux on x86 and x86-64).
>
> They also make libsmbios an optional input to fwupd (its only dependent),
> allowing fwupd to build successfully on non-Intel/AMD platforms.
>
> I've tested this on AArch64 and x86-64 and everything appears fine.  I've been
> unable to test cross-building fwupd, though, as this fails with
>
>   guix build: error: gnu/packages/gnome.scm:3504:2: librsvg@2.56.4: build
>   system `cargo' does not support cross builds
>
> By way of justification for these changes: libsmbios is intended for PCs and
> expects[1] to find a sys/io.h header file on the host.  This is supplied by
> glibc only for architectures that support peripheral I/O via ports: x86,
> x86-64 and DEC Alpha using Linux; and i386 using the Hurd[2].
>
> Of these Guix does not support Linux on Alpha, while libsmbios does not
> support the Hurd at all[3].
>
> --
> Simon South
> simon@simonsouth.net
>
> [0] https://en.wikipedia.org/wiki/System_Management_BIOS
>
> [1] 
> https://github.com/dell/libsmbios/blob/v2.4.3/src/libsmbios_c/cmos/cmos_linux.c#L25
>
> [2] "find -type f -name 'io.h'" at the top level of glibc's source tree makes
>     this apparent.
>
> [3] 
> https://github.com/dell/libsmbios/blob/v2.4.3/src/libsmbios_c/common/select_platform_config.h
>
>
> Simon South (2):
>   gnu: libsmbios: Restrict to only supported systems.
>   gnu: fwupd: Depend on libsmbios only on supported systems.
>
>  gnu/packages/firmware.scm | 34 +++++++++++++++++++---------------
>  gnu/packages/hardware.scm |  1 +
>  2 files changed, 20 insertions(+), 15 deletions(-)
>
>
> base-commit: ac69b423865f12310cef5662d9c303aa4b90c869
> -- 
> 2.41.0
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: [bug#68263] [PATCH v2 0/2] libsmbios: Restrict to only supported systems.
>
>
>
>
> Date: 
>
> Fri, 12 Jan 2024 17:03:23 +0100
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13)
>
>
>
>
> Hello,
>
> > Here's a revised version of this patchset, incorporating Mathieu Othacehe's
> > advice regarding the use of %current-target-system with supported-package?
> > (but using and=> for compactness and efficiency).
> >
> > I've tested cross-building fwupd from AArch64 to x86-64 and vice-versa and
> > things now work as expected, apart from the nspr package failing to build due
> > to what appears to be a limitation of its own build script.
>
> Thanks for the v2. Applied!
>
> Mathieu
>
>
> --- End Message ---