bug#69493: closed (30.0.50; Preferable choice of coding system on Japanese)

[GNU bug Tracking System]

Your message dated Sat, 02 Mar 2024 09:07:06 +0200
with message-id <86v865p0x1.fsf@gnu.org>
and subject line Re: bug#69493: 30.0.50; Preferable choice of coding system on 
Japanese
has caused the debbugs.gnu.org bug report #69493,
regarding 30.0.50; Preferable choice of coding system on Japanese
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs@gnu.org.)


-- 
69493: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69493
GNU Bug Tracking System
Contact help-debbugs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 30.0.50; Preferable choice of coding system on Japanese
>
>
>
>
> Date: 
>
> Sat, 02 Mar 2024 08:44:56 +0900
>
>
>
>
> User-agent: 
>
> Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (Gojō) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO)
>
>
>
>
> When I call (set-language-environment "Japanese"), below code in
> lisp/language/japan-util.el is called.
>
> (defun setup-japanese-environment-internal ()
>   (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
>                             'japanese-shift-jis
>                           'utf-8))
>   (use-cjk-char-width-table 'ja_JP))
>
> 1. japanese-shift-jis is not proper coding system on Cygwin.
> 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
>
> PLease see below patch.
>
> diff --git a/lisp/language/japan-util.el b/lisp/language/japan-util.el
> index 93e8ab24971..f3ec44bf75d 100644
> --- a/lisp/language/japan-util.el
> +++ b/lisp/language/japan-util.el
> @@ -29,8 +29,8 @@
>  
>  ;;;###autoload
>  (defun setup-japanese-environment-internal ()
> -  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> -                           'japanese-shift-jis
> +  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos))
> +                           'japanese-cp932
>                           'utf-8))
>    (use-cjk-char-width-table 'ja_JP))
>
>
>
> -- 
> Kazuhiro Ito
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#69493: 30.0.50; Preferable choice of coding system on Japanese
>
>
>
>
> Date: 
>
> Sat, 02 Mar 2024 09:07:06 +0200
>
>
>
>
> > Date: Sat, 02 Mar 2024 08:44:56 +0900
> > From: Kazuhiro Ito <kzhr@d1.dion.ne.jp>
> > 
> > When I call (set-language-environment "Japanese"), below code in
> > lisp/language/japan-util.el is called.
> > 
> > (defun setup-japanese-environment-internal ()
> >   (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> >                           'japanese-shift-jis
> >                         'utf-8))
> >   (use-cjk-char-width-table 'ja_JP))
> > 
> > 1. japanese-shift-jis is not proper coding system on Cygwin.
> > 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
> > 
> > PLease see below patch.
>
> Thanks, installed on the master branch, and closing the bug.
>
> P.S. Please in the future try to submit patches in the format produced
> by "git format-patch" -- that makes applying the patches much easier.
>
>
> --- End Message ---