[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: save-frame-excursion?
From: |
Bastien |
Subject: |
Re: save-frame-excursion? |
Date: |
Tue, 28 Jul 2009 05:05:16 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) |
Stefan Monnier <address@hidden> writes:
>> This patch makes sure that `make-frame' gives the focus back to the
>> previously selected frame.
>> Shall I apply this?
>
> Don't know. Here are some comments:
> - does it work (as in "with
> Metacity/W32/macosx/xmonad/addyourfavoriteWMhere")?
I don't have access to all these WM, I'm sending the patch here to get
feedback about this.
> - as Stephen pointed out, it should be run before the hook.
Yes.
> - it's not clear that it does the right thing if the selected-frame
> is not the frame with focus (basically we'd need a focussed-frame
> function to figure it out).
Yes, a focused-frame would be nice.
> - it brings us back to this problem of "focus via activation".
> - is x-focus-frame always defined when this code is run (i.e. can't
> this code be run also on emacs-nox)?
So maybe a variant of this patch should better be applied to
make-frame-command, which handle this distinction between x/nox.
> - x-focus-frame should really be renamed (so as to get rid of the "x-"
> prefix at least).
Okay. I can't do the job about renaming x-focus-frame and creating the
focused-frame function so I guess my fix will wait for that.
Thanks,
--
Bastien
- Re: save-frame-excursion?, (continued)
- Re: save-frame-excursion?, Stefan Monnier, 2009/07/25
- Re: save-frame-excursion?, Bastien, 2009/07/25
- Re: save-frame-excursion?, Stefan Monnier, 2009/07/25
- Re: save-frame-excursion?, Bastien, 2009/07/25
- Re: save-frame-excursion?, Stefan Monnier, 2009/07/26
- RE: save-frame-excursion?, Drew Adams, 2009/07/26
- Re: save-frame-excursion?, Bastien, 2009/07/26
- Re: save-frame-excursion?, Stephen J. Turnbull, 2009/07/27
- Re: save-frame-excursion?, Bastien, 2009/07/27
- Re: save-frame-excursion?, Stefan Monnier, 2009/07/27
- Re: save-frame-excursion?,
Bastien <=
- Re: save-frame-excursion?, Stefan Monnier, 2009/07/27