|
From: | Bozhidar Batsov |
Subject: | Re: Small improvements to ruby-mode |
Date: | Fri, 5 Jul 2013 16:01:27 +0300 |
On 05.07.2013 13:56, Bozhidar Batsov wrote:Thanks for the catch.
The patch looks good with one minor problem - you've included `autoload`
twice (the second time it's in Module's methods).
Yeah, I guess.
While on the subject of small improvements here's a few more ideas:
* replace cl with cl-lib (that should be done eventually I guess)
What exactly do you propose to change? If the file is installed manually, and if it's not autoloaded, the user has to add some auto-mode-alist entries.
* update the front-matter comment since it's pretty out-of-date
Untabify, you mean? It's the core's policy not to touch tabs vs. spaces until you meaningfully modify nearby code.
* run a whitespace cleanup on the code :-)
Have you looked at https://github.com/pd/yard-mode.el/ ?
* highlight yard and rdoc special syntax in comments - like Emacs Lisp does
The only problem with it I can see is, it sets eldoc-documentation-function, so it can't be used outside of comments. I guess we'll eventually need eldoc-documentation-functions hook, like we have for completions.
Uh, okay. Is it different from the default face, in any themes?
* make use of `font-lock-negation-char-face` for !
I think highlighting backslash sequences is more important, and the two approaches are somewhat incompatible. See:
* maybe make of use of new `font-log-regexp-grouping-construct-face` as well
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14481
https://github.com/dgutov/highlight-escape-sequences
P.S. Please try to keep emacs-devel in Cc.
[Prev in Thread] | Current Thread | [Next in Thread] |