[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch for warnings in 64bit Windows builds
From: |
Eli Zaretskii |
Subject: |
Re: Patch for warnings in 64bit Windows builds |
Date: |
Fri, 31 Jul 2015 09:55:43 +0300 |
> From: Andy Moreton <address@hidden>
> Date: Thu, 30 Jul 2015 22:09:51 +0100
>
> I've noticed some other warnings in the 64bit mingw64 builds requiring
> a similar fix:
>
> ../../src/w32.c: In function 'maybe_load_unicows_dll':
> ../../src/w32.c:9174:25: warning: assignment from incompatible pointer type
> [-Wincompatible-pointer-types]
> pMultiByteToWideChar = GetProcAddress (ret, "MultiByteToWideChar");
> ^
> ../../src/w32.c:9175:25: warning: assignment from incompatible pointer type
> [-Wincompatible-pointer-types]
> pWideCharToMultiByte = GetProcAddress (ret, "WideCharToMultiByte");
> ^
>
> There is also a warning about socket handling:
>
> ../../src/w32.c: In function 'sys_socket':
> ../../src/w32.c:7336:14: warning: overflow in implicit constant conversion
> [-Woverflow]
> return INVALID_SOCKET;
> ^
> c:/msys64/mingw64/x86_64-w64-mingw32/include/psdk_inc/_socket_types.h
> contains:
>
> #if 1
> typedef UINT_PTR SOCKET;
> #else
> typedef INT_PTR SOCKET;
> #endif
>
> #define INVALID_SOCKET (SOCKET)(~0)
>
> Thus it is corect to warn about a conversion from unsigned 64bit to a
> signed 32bit value.
Please propose changes to eliminate those. (I can propose them
myself, but I cannot test them.)
> >> I don't have copyright paperwork on file, so please let me know if that
> >> is required.
> >
> > Not needed, but you are encouraged to start the paperwork rolling, so
> > it will be ready for your next contribution.
>
> Where do I find the appropriate forms ?
One place is in Gnulib's Git repository, in the doc/Copyright/
directory. You want the file request-assign.future. There are some
explanations in
https://www.gnu.org/prep/maintain/html_node/Copyright-Papers.html, but
the form is pretty much self-explanatory.
Thanks.