Re: master 223e7b8: Make CC Mode and electric-pair-mode work together. This fixes bug #33794

[Alan Mackenzie]

Hello, Michael.

On Wed, Jan 16, 2019 at 00:30:26 +0100, Michael Albinus wrote:
> address@hidden (Alan Mackenzie) writes:

> Hi Alan,

> > branch: master
> > commit 223e7b87872d4a010ae1c9a6f09a9c15aee46692
> > Author: Alan Mackenzie <address@hidden>
> > Commit: Alan Mackenzie <address@hidden>

> >     Make CC Mode and electric-pair-mode work together.  This fixes bug 
> > #33794

> This seems to break electric-tests.el:

Thanks!  Part of the problem is in CC Mode, still.  Another part of the
problem is electric-tests.el making assumptions about CC Mode's
implementation (which has recently changed).  Thanks for reminding me to
run make check.  ;-(

Incidentally, there's a test engine in electric-tests.el which is 100%
undocumented (no doc string, no comments in functions like
electric-pair-test-for and electric-pair-define-test-form).  It would be
appreciated if anybody reading this who understands any of these
functions could add doc strings to them.

> --8<---------------cut here---------------start------------->8---
> # make -C test electric-tests
> Ran 475 tests, 387 results as expected, 88 unexpected (2019-01-16 
> 00:28:55+0100, 214.752138 sec)
> 1 expected failures

> 88 unexpected results:
>    FAILED  electric-layout-int-main-allman-style
>    FAILED  electric-layout-int-main-kernel-style

[ .... ]

>    FAILED  electric-pair-whitespace-jumping-at-point-8-in-c++-mode-in-comments
>    FAILED  electric-pair-whitespace-jumping-at-point-9-in-c++-mode-in-comments

[ .... ]

> Best regards, Michael.

-- 
Alan Mackenzie (Nuremberg, Germany).