[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Does service lookup by name work on Windows now?
From: |
Robert Pluim |
Subject: |
Re: Does service lookup by name work on Windows now? |
Date: |
Mon, 28 Jan 2019 11:12:15 +0100 |
Eli Zaretskii <address@hidden> writes:
>> Iʼd really like to remove that workaround, but I could leave it in,
>> conditioned on (eq system-type 'windows-nt) or similar.
>
> Conditioning is fine with me. We could also look at
>
> (car (x-server-version))
>
> It should be 5 or less for XP and older systems.
This is what I have so far.
>From 696e57b862b9d525aae1a735f922025d8fa40bfd Mon Sep 17 00:00:00 2001
From: Robert Pluim <address@hidden>
Date: Sun, 27 Jan 2019 16:13:46 +0100
Subject: [PATCH] Don't map imaps to 993 anymore except on old Windows versions
To: address@hidden
'open-network-stream' will do the imaps service lookup itself, and
using 993 forced the user to use the numeric value in .authinfo for
certificate lookups.
* lisp/gnus/nnimap.el (nnimap-map-port): Only do mapping for Windows
XP or earlier.
---
lisp/gnus/nnimap.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/gnus/nnimap.el b/lisp/gnus/nnimap.el
index 75b5af8aab..9646bb51d0 100644
--- a/lisp/gnus/nnimap.el
+++ b/lisp/gnus/nnimap.el
@@ -413,8 +413,11 @@ nnimap-open-connection
nil
stream)))
+;; This is only needed for Windows XP or earlier
(defun nnimap-map-port (port)
- (if (equal port "imaps")
+ (if (and (eq system-type 'windows-nt)
+ (<= (car (x-server-version)) 5)
+ (equal port "imaps"))
"993"
port))
--
2.20.1.142.g77556354bb
- Re: Does service lookup by name work on Windows now?, (continued)
- Re: Does service lookup by name work on Windows now?, Eli Zaretskii, 2019/01/26
- Re: Does service lookup by name work on Windows now?, Robert Pluim, 2019/01/26
- Re: Does service lookup by name work on Windows now?, Eli Zaretskii, 2019/01/26
- Re: Does service lookup by name work on Windows now?, Richard Stallman, 2019/01/26
- Re: Does service lookup by name work on Windows now?, Tim Cross, 2019/01/27
- Re: Does service lookup by name work on Windows now?, Alexandre Garreau, 2019/01/27
- Re: Does service lookup by name work on Windows now?, Richard Stallman, 2019/01/27
- Re: Does service lookup by name work on Windows now?, Eli Zaretskii, 2019/01/27
- Re: Does service lookup by name work on Windows now?, Alexandre Garreau, 2019/01/28
- Re: Does service lookup by name work on Windows now?, Richard Stallman, 2019/01/29
- Re: Does service lookup by name work on Windows now?,
Robert Pluim <=
- Re: Does service lookup by name work on Windows now?, Eli Zaretskii, 2019/01/28