Re: Proposed changes to gnus-dup.el

[Basil L. Contovounesios]

Eric Abrahamsen <address@hidden> writes:

> "Basil L. Contovounesios" <address@hidden> writes:
>
>> "Basil L. Contovounesios" <address@hidden> writes:
>>
>>> Eric Abrahamsen <address@hidden> writes:
>>>
>>>> On 03/25/19 18:13 PM, Basil L. Contovounesios wrote:
>>>>>
>>>>> I will wait a few more days for people to comment and push the
>>>>> rest of the patch if there are no serious objections.
>>>>
>>>> If I end up backing out the hash-table changes, will this patch still
>>>> apply correctly?
>>>
>>> The original patch I sent will conflict with the hunks where you added
>>> docstrings to gnus-dup-{list,hashtb} and switched from obarray to
>>> hash-table operations.
>>>
>>> It would be easy for me to resolve these minor conflicts, but if that's
>>> going to get in your way of more pressing work, then I'll hold off.
>>> (That's not to say I think you should revert the hash-table changes.)
>>
>> Eric, just to be clear: may I push these minor changes, or would you
>> rather I held off?
>
> Oh, sorry -- I'd assumed you'd already pushed them! They're good to go
> as far as I'm concerned: in for a penny, in for a pound.

Thanks, pushed.

[1: 2bd3e48404]: * lisp/gnus/gnus-dup.el: Use lexical-binding
  2019-04-03 02:55:41 +0100
  
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=2bd3e484041b2b7ea47c236b86f59610d971b609

-- 
Basil