[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-env
|
From: |
Eli Zaretskii |
|
Subject: |
Re: [Emacs-diffs] master 1072155: Avoid duplicate entries in process-environment after re-dumping |
|
Date: |
Wed, 03 Apr 2019 20:32:26 +0300 |
> Date: Wed, 3 Apr 2019 09:58:35 -0700
> From: "Daniel Colascione" <address@hidden>
> Cc: "Daniel Colascione" <address@hidden>,
> address@hidden
>
> >> We "support" dumping only from dedicated batch instances in that for now
> >> we should consider only bugs in that use case release-blocking, but I
> >> don't want to gratuitously break other use cases like dumping
> >> interactive
> >> sessions without killing them, since these use cases are meant to work
> >> and
> >> we'll give them the same level of support someday soon.
> >
> > OK, but is there any reason dump_unwind_cleanup doesn't restore
> > post-gc-hook? Omission?
>
> Not restoring post-gc-hook is a bug. Thanks for spotting that!
Thanks, I fixed both issues.