[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
commit 8147d3c27c breaks grep over tramp
From: |
John Shahid |
Subject: |
commit 8147d3c27c breaks grep over tramp |
Date: |
Tue, 09 Apr 2019 10:28:15 -0400 |
User-agent: |
mu4e 1.1.0; emacs 27.0.50 |
Hi all,
Looks like commit 8147d3c27c breaks `grep' when ran on a remote host
using tramp. Previous to the commit I would see the list of grep hits,
but after this commit there is a command prompt as part of the grep
hits. This makes the first hit unclickable. I bisected the history to
find the offending commit and found the following change to be the
cause:
> @@ -2912,8 +2903,7 @@ tramp-sh-handle-make-process
> ;; otherwise we might be interrupted by
> ;; `verify-visited-file-modtime'.
> (let ((buffer-undo-list t)
> - (inhibit-read-only t)
> - (mark (point-max)))
> + (inhibit-read-only t))
> (clear-visited-file-modtime)
> (narrow-to-region (point-max) (point-max))
> ;; We call `tramp-maybe-open-connection', in
> @@ -2926,9 +2916,7 @@ tramp-sh-handle-make-process
> (let ((pid (tramp-send-command-and-read v "echo $$")))
> (process-put p 'remote-pid pid)
> (tramp-set-connection-property p "remote-pid" pid))
> - (widen)
> - (delete-region mark (point-max))
> - (narrow-to-region (point-max) (point-max))
> + (delete-region (point-min) (point-max))
Is anyone else seeing the same thing or is it something with my
configuration ?
Cheers,
JS
- commit 8147d3c27c breaks grep over tramp,
John Shahid <=