emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Ignore pending_signals when checking for quits.


From: Philipp Stephani
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Fri, 19 Apr 2019 21:06:48 +0200

Am So., 24. Feb. 2019 um 22:51 Uhr schrieb Philipp Stephani
<address@hidden>:
>
> Am Mi., 13. Feb. 2019 um 16:29 Uhr schrieb Eli Zaretskii <address@hidden>:
> >
> > > From: Philipp Stephani <address@hidden>
> > > Cc: Philipp Stephani <address@hidden>
> > > Date: Mon, 11 Feb 2019 21:17:39 +0100
> > >
> > > pending_signals is often set if no quit is pending.  This results in
> > > bugs in module code if the module returns but no quit is actually
> > > pending.
> > >
> > > As a better alternative, add a new process_input environment function
> > > for Emacs 27.  That function processes signals (like maybe_quit).
> >
> > Thanks, this LGTM.
>
> Thanks, pushed as 72ec233f2a.

Question: Would it be OK to backport the first part (using QUITP in
module_should_quit) to Emacs 26.3? Right now should_quit behaves
erratically: it occasionally quits, but in other instances doesn't
because pending_signals has been reset in the meantime.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]