[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] master 905f619: Don't check comp-buffer-name-function in d
From: |
Noam Postavsky |
Subject: |
[Emacs-diffs] master 905f619: Don't check comp-buffer-name-function in derived mode (Bug#34956) |
Date: |
Thu, 4 Apr 2019 19:40:41 -0400 (EDT) |
branch: master
commit 905f6195191a518b7bb2dbdf6eacae41d31fc54e
Author: Troy Hinckley <address@hidden>
Commit: Noam Postavsky <address@hidden>
Don't check comp-buffer-name-function in derived mode (Bug#34956)
* lisp/progmodes/compile.el (define-compilation-mode): Remove
'compilation-buffer-name-function' from the list of overridden
variables to ensure that it is not mistaken for a variable that can be
major mode specific. 'compilation-buffer-name-function' is used
before the major mode is loaded, therefore overriding it here is
ineffectual. Also, the function 'compilation-start' takes an optional
argument name-function, so there is already a mechanism to override
it.
---
lisp/progmodes/compile.el | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6d57752..1a0d9bd 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -2056,8 +2056,7 @@ by replacing the first word, e.g.,
`compilation-scroll-output' from
(if (boundp 'byte-compile-bound-variables)
(memq (cdr v) byte-compile-bound-variables)))
`(set (make-local-variable ',(car v)) ,(cdr v))))
- '(compilation-buffer-name-function
- compilation-directory-matcher
+ '(compilation-directory-matcher
compilation-error
compilation-error-regexp-alist
compilation-error-regexp-alist-alist
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Emacs-diffs] master 905f619: Don't check comp-buffer-name-function in derived mode (Bug#34956),
Noam Postavsky <=