[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/eglot2emacs 6717589c57 086/120: Be more conservative with the ls
From: |
João Távora |
Subject: |
feature/eglot2emacs 6717589c57 086/120: Be more conservative with the lsp identifier guess |
Date: |
Thu, 20 Oct 2022 07:17:01 -0400 (EDT) |
branch: feature/eglot2emacs
commit 6717589c57edb96c7050df7d33cfcdc805a0eaec
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>
Be more conservative with the lsp identifier guess
If the user is not requesting a prompt, opt for the safer approach
which is to get the location from textDocument/definition, not from
workspace/symbol. Because of things like function overloading, the
latter is not always successful in finding exactly the definition of
the thing one is invoking M-. on.
This requires using an xref-internal symbol, which is kind of
unfortunate.
* eglot.el (xref-backend-identifier-at-point): Rework.
GitHub-reference: per https://github.com/joaotavora/eglot/issues/131
GitHub-reference: per https://github.com/joaotavora/eglot/issues/314
---
lisp/progmodes/eglot.el | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 22eff41f53..0b64cd2301 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2458,10 +2458,11 @@ If BUFFER, switch to it before."
(cl-defmethod xref-backend-identifier-at-point ((_backend (eql eglot)))
(let ((attempt
- (puthash :default
- (ignore-errors
- (eglot--workspace-symbols (symbol-name (symbol-at-point))))
- eglot--workspace-symbols-cache)))
+ (and (xref--prompt-p this-command)
+ (puthash :default
+ (ignore-errors
+ (eglot--workspace-symbols (symbol-name
(symbol-at-point))))
+ eglot--workspace-symbols-cache))))
(if attempt (car attempt) "LSP identifier at point")))
(defvar eglot--lsp-xref-refs nil
- feature/eglot2emacs a35f6a7f9a 010/120: Support language server for html, css, json and docker, (continued)
- feature/eglot2emacs a35f6a7f9a 010/120: Support language server for html, css, json and docker, João Távora, 2022/10/20
- feature/eglot2emacs b527764963 023/120: Support racket-langserver, João Távora, 2022/10/20
- feature/eglot2emacs eacc40e3bf 015/120: ; update copyright years, João Távora, 2022/10/20
- feature/eglot2emacs 1616da4f26 030/120: * eglot.el (eglot-strict-mode): very minor docfix., João Távora, 2022/10/20
- feature/eglot2emacs 6a6f4c3d27 041/120: Don't use :exclusive no, João Távora, 2022/10/20
- feature/eglot2emacs 26bd153b90 028/120: Print server command to events buffer, João Távora, 2022/10/20
- feature/eglot2emacs abfb193201 032/120: Remove unnecessary compatibility code, João Távora, 2022/10/20
- feature/eglot2emacs 85ecf46a18 046/120: Have a couple of lsp faces inherit from basic "shadow", João Távora, 2022/10/20
- feature/eglot2emacs 6d815aaa98 057/120: Tweak on-type-formatting code, João Távora, 2022/10/20
- feature/eglot2emacs b59fa2548e 083/120: Cosmetic decisions guaranteed to tick off someone somewhere (tm), João Távora, 2022/10/20
- feature/eglot2emacs 6717589c57 086/120: Be more conservative with the lsp identifier guess,
João Távora <=
- feature/eglot2emacs 3967d22b9c 005/120: ; fix typos, João Távora, 2022/10/20
- feature/eglot2emacs 5c6eb3caa9 074/120: Don't ignore flymake-no-changes-timeout, João Távora, 2022/10/20
- feature/eglot2emacs 6ee995fe6b 094/120: Add marksman server for markdown, João Távora, 2022/10/20
- feature/eglot2emacs 0e8a8697ba 092/120: Merge commit '7738854e09' to fix fallout of force-push in gnu elpa, João Távora, 2022/10/20
- feature/eglot2emacs 51ae66b50c 099/120: Add eglot-show-configuration to debug workspace configurations, João Távora, 2022/10/20
- feature/eglot2emacs 14586fedcf 103/120: Don't exceed max-specdl-size in big go projects, João Távora, 2022/10/20
- feature/eglot2emacs a8b3b6a526 014/120: Add vim-language-server for vimrc-mode, João Távora, 2022/10/20
- feature/eglot2emacs b1c7aa1d17 003/120: Add yaml-language-server for yaml-mode, João Távora, 2022/10/20
- feature/eglot2emacs 51fc8fc3d2 002/120: Use `locate-user-emacs-file` instead of `concat`, João Távora, 2022/10/20
- feature/eglot2emacs 06f1cd6365 008/120: Add lua-lsp support for lua-mode, João Távora, 2022/10/20