emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master cb8918d7cc: ; Fix unclean code in w32fns.c


From: Eli Zaretskii
Subject: master cb8918d7cc: ; Fix unclean code in w32fns.c
Date: Sun, 30 Oct 2022 08:46:20 -0400 (EDT)

branch: master
commit cb8918d7cc028988bad79b66cbf577f2f37413e1
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

    ; Fix unclean code in w32fns.c
    
    * src/w32fns.c (setup_w32_kbdhook): Fix a typo and check errors
    from the call to StringFromGUID2.  Reported by Juanma Barranquero
    <lekktu@gmail.com>.
---
 src/w32fns.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/w32fns.c b/src/w32fns.c
index 5f652ae9e4..93b7f80f26 100644
--- a/src/w32fns.c
+++ b/src/w32fns.c
@@ -2734,8 +2734,7 @@ setup_w32_kbdhook (void)
          int i;
 
          CoCreateGuid (&guid);
-         StringFromGUID2 (&guid, newTitle, 64);
-         if (newTitle != NULL)
+         if (oldTitle != NULL && StringFromGUID2 (&guid, newTitle, 64))
            {
              GetConsoleTitleW (oldTitle, 1024);
              SetConsoleTitleW (newTitle);



reply via email to

[Prev in Thread] Current Thread [Next in Thread]