emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

feature/android d33bf0a0afd: Remove synchronization around `damageRegion


From: Po Lu
Subject: feature/android d33bf0a0afd: Remove synchronization around `damageRegion'
Date: Sat, 27 May 2023 03:20:07 -0400 (EDT)

branch: feature/android
commit d33bf0a0afddb76598aa020f68402d0e19cfb65c
Author: Po Lu <luangruo@yahoo.com>
Commit: Po Lu <luangruo@yahoo.com>

    Remove synchronization around `damageRegion'
    
    * java/org/gnu/emacs/EmacsView.java (EmacsView, swapBuffers):
    Remove unnecessary documentation.  `damageRegion' is only
    changed from the Emacs thread.
---
 java/org/gnu/emacs/EmacsView.java | 26 ++++++++++----------------
 1 file changed, 10 insertions(+), 16 deletions(-)

diff --git a/java/org/gnu/emacs/EmacsView.java 
b/java/org/gnu/emacs/EmacsView.java
index 124ea5301bb..eb1d88ae242 100644
--- a/java/org/gnu/emacs/EmacsView.java
+++ b/java/org/gnu/emacs/EmacsView.java
@@ -338,10 +338,7 @@ public final class EmacsView extends ViewGroup
   public void
   damageRect (Rect damageRect)
   {
-    synchronized (damageRegion)
-      {
-       damageRegion.union (damageRect);
-      }
+    damageRegion.union (damageRect);
   }
 
   /* This method is called from both the UI thread and the Emacs
@@ -358,22 +355,19 @@ public final class EmacsView extends ViewGroup
 
     /* Now see if there is a damage region.  */
 
-    synchronized (damageRegion)
-      {
-       if (damageRegion.isEmpty ())
-         return;
+    if (damageRegion.isEmpty ())
+      return;
 
-       /* And extract and clear the damage region.  */
+    /* And extract and clear the damage region.  */
 
-       damageRect = damageRegion.getBounds ();
-       damageRegion.setEmpty ();
+    damageRect = damageRegion.getBounds ();
+    damageRegion.setEmpty ();
 
-       bitmap = getBitmap ();
+    bitmap = getBitmap ();
 
-       /* Transfer the bitmap to the surface view, then invalidate
-          it.  */
-       surfaceView.setBitmap (bitmap, damageRect);
-      }
+    /* Transfer the bitmap to the surface view, then invalidate
+       it.  */
+    surfaceView.setBitmap (bitmap, damageRect);
   }
 
   @Override



reply via email to

[Prev in Thread] Current Thread [Next in Thread]