emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 27a57f4cca5 2/2: * src/androidvfs.c (android_saf_file_open): Impr


From: Po Lu
Subject: master 27a57f4cca5 2/2: * src/androidvfs.c (android_saf_file_open): Improve commentary.
Date: Tue, 8 Aug 2023 02:11:26 -0400 (EDT)

branch: master
commit 27a57f4cca55fd64a61eb8952b6422712f27b0af
Author: Po Lu <luangruo@yahoo.com>
Commit: Po Lu <luangruo@yahoo.com>

    * src/androidvfs.c (android_saf_file_open): Improve commentary.
---
 src/androidvfs.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/androidvfs.c b/src/androidvfs.c
index 0ee555c0ad4..93927ccc86b 100644
--- a/src/androidvfs.c
+++ b/src/androidvfs.c
@@ -5622,21 +5622,23 @@ android_saf_file_open (struct android_vnode *vnode, int 
flags,
 
   /* Open a parcel file descriptor according to flags.  Documentation
      for the SAF openDocument operation is scant and seldom helpful.
-     It's clear that their file access modes are inconsistently
-     implemented, and that at least:
+     From observations made, it is clear that their file access modes
+     are inconsistently implemented, and that at least:
 
        r   = either an FIFO or a real file, without truncation.
-       w   = either an FIFO or a real file, with truncation.
+       w   = either an FIFO or a real file, with OR without truncation.
        wt  = either an FIFO or a real file, with truncation.
        rw  = a real file, without truncation.
        rwt = a real file, with truncation.
 
      This diverges from the self-contradicting documentation, where
-     openDocument says nothing about truncation, and openFile, where
-     w can elect not to truncate.
+     openDocument says nothing about truncation, and openFile mentions
+     that w can elect not to truncate and programs which rely on
+     truncation should use wt.
 
      Since Emacs is prepared to handle FIFOs within fileio.c, simply
-     use the straightforward relationships possible.  */
+     specify the straightforward relationship between FLAGS and the
+     file access modes listed above.  */
 
   method = service_class.open_document;
   read = trunc = write = false;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]