Re: [O] ob-clojure with tangling current broken

[stardiviner]

Frederick Giasson <address@hidden> writes:

> Hi,
>
> I updated org-mode to latest dev version recently and I was wondering why I 
> was
> seeing namespaces appended to each [clojure] code block I was tangling (which
> generates unusable tangled Clojure source files)


That's why I added a patch recently. Now Nicolas already applied my
patch. You should already seen it now.

>
> It turns out that the culprit is the following line:
> https://code.orgmode.org/bzg/org-mode/src/master/lisp/ob-clojure.el#L108
>
> I am wondering why is there such code injection in
> "org-babel-expand-body:clojure". It looks like to be related to the Clojure 
> code
> block execution, but it also appears to be called from the tangling function.
> Clearly those two different use cases needs to be properly handled at the 
> level
> of "ob-clojure.el"
>

Expanding clojure code is necessary to tangling, because when user have
noweb reference etc in source block, expanding here is necessary.

> I didn't follow all the changes to the "ob-clojure" mode in the last year or 
> so,
> so please pardon my ignorance if the module is taking a different direction 
> than
> I am used to. Is there a rational behind this behaviour or is there a new 
> feature
> that I am not aware of which properly handle those two use cases?
>

Which part you don't understand, I might can answer your question,
because I did most of those changes in last year.

> Thanks,
>
> Take care,
>
> Fred


--
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3