[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] Add feature to org-drill to auto pronounce word
From: |
stardiviner |
Subject: |
Re: [O] [PATCH] Add feature to org-drill to auto pronounce word |
Date: |
Sun, 27 Jan 2019 10:50:13 +0800 |
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Nicolas Goaziou <address@hidden> writes:
> Hello,
>
> stardiviner <address@hidden> writes:
>
>> A gentle ping..
>
> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing
> Paul Sexton. In the long run, I think this package could be packaged
> through ELPA instead.
It is indeed not actively maintained. But still has some user are using
it. I found some recently used in Org Mode ML mentioned it.
I will ping the author Paul Sexton, I would like to particited in
maintain it. If he agree to publish it to MELPA, I could help.
>
>>> * etc/ORG-NEWS: mentioned this new feature.
>
> Changes to "contrib/" directory are usually not mentioned in this
> file.
Removed now.
>
>>> +(defun org-drill-pronounce-word ()
>>> + "Pronounce word after querying."
>>> + (if org-drill-auto-pronounce
>>> + (shell-command-to-string
>>> + (format "%s %s %s &"
>>> + org-drill-pronounce-command org-drill-pronounce-command-args
>
> What are `org-drill-pronounce-command' and
> `org-drill-pronounce-command-args'? I don't see them defined anywhere.
>
I missed that. Now added.
> Also, please prefer `when' to one-armed `if'.
Modified.
>
>>> + (shell-quote-argument
>>> + (substring-no-properties
>>> + (org-get-heading 'no-tags 'no-todo 'no-priority
>>> 'no-comment)))))))
>>> +
>>> +(add-hook 'org-drill-entry-after-hook #'org-drill-pronounce-word)
>
> Could it be more integrated? Using hook is usually for users. If you can
> modify the code, you probably can do better.
Modified now.
Those two hooks I think is necessary for user to add custom actions. So
keep them.
>
> Regards,
Regards :)
--
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3