Re: [fluid-dev] Fix for problem with CC changes to Bank MSB

[David Henningsson]

D.Bartolec skrev:
> I've discovered it after playing some MIDI files that would send bank LSB:0 
> for drum channel without sending bank MSB at all.
> This would cause drum tracks to change to MSB:0 LSB:0. 

I've taken a quick look at your patch now and I have a question:

> +  if ( (chan == 9) && (bank_msb == 0))
> +  {      
> +   bank_msb = 1; /* Ignore CC value and set the default MSB value for drum 
> channel */
> +  }

Is this part really necessary, and does it disable a previous
possibility to assign a regular instrument to the drum channel?

Otherwise I think it makes sense - LSB setting does not affect MSB
setting, and the other way around.

A question to the audience: Why do we have variables for banknum and
prognum in fluid_channel_t, when they can be read from (and written to)
the CC array?

// David