Re: [fluid-dev] [PATCH] sampledata caching

[David Henningsson]

On 10/10/2012 10:29 AM, Kjetil Matheussen wrote:
> On 10.10.2012 09:51, Kjetil Matheussen wrote:
> > > Another thing we need to verify is that the sampledata is read-only
> > > once it's been bigendian converted. If it is not, chances are that two
> > > threads would both modify the sampledata, causing problems.
> >
> > Okay. I'll see if there's any trouble changing the sampledata field
> > from short* to const short*.
>
> There was no problems setting _fluid_sample_t->data and
> _fluid_defsfont_t->sample
> to const short*.
>
> The only warning I got which made me somewhat worried was in
> fluid_ramsfont.c where
> FLUID_FREE(sample->data) is called a couple of times. If this
> sample->data pointer
> is created in fluid_defsfont.c, it would be a problem, but I guess it
> isn't.

No, that should be safe. Defsfonts shouldn't try to interact with 
ramsfonts anyway.

I've committed your patch now, after fixing a compiler warning and an 
unprotected read of all_cached_sampledata. Thanks for your contribution! :-)

// David