Re: [fluid-dev] Enable/disable logging at configure time

[Tom M.]

Every implementation is free to override any part of fluid_sys.h and fluidsynth_priv.h; introducing a cmake option for this minor change might be an overkill. If you still think a cmake option is the best way to go it should also make sure that this fluid_log* stuff in fluid_sys.c does not get compiled.

Tom

2017-10-29 11:58 GMT+01:00 Carlo Bramini <address@hidden>:

Hello,

I would like to suggest the addition of an option "disable-logging" in the cmake script, that will allow the user to de-activate the log prints.
In the code, this just means a change like this into fluidsynth_priv.h:

#ifdef DISABLE_FLUID_LOG
#define FLUID_LOG
#else
#define FLUID_LOG    fluid_log
#endif

It saves some memory if someone wants (about 12KB on an ARM Thumb2 microcontroller) and it would be selectable by the user (logging will be activated by default).

What do you think?
Sincerely.

_______________________________________________
fluid-dev mailing list
address@hidden
https://lists.nongnu.org/mailman/listinfo/fluid-dev