freetype-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[freetype2-demos] ftbench-gsoc-goksu fb6dd3e 08/17: [ftbench] Use proper


From: Werner Lemberg
Subject: [freetype2-demos] ftbench-gsoc-goksu fb6dd3e 08/17: [ftbench] Use proper `face_requester`.
Date: Sat, 20 May 2023 08:29:41 -0400 (EDT)

branch: ftbench-gsoc-goksu
commit fb6dd3ee28e33b09b48db983ac723b8698ca6001
Author: Alexei Podtelezhnikov <apodtele@gmail.com>
Commit: Alexei Podtelezhnikov <apodtele@gmail.com>

    [ftbench] Use proper `face_requester`.
    
    It is wrong to forfeit the face ownership to the cache manager. Fixes #29.
    
    * src/ftbench.c (face_requester): Call `get face`.
    (main): Never pass `face` to the cache manager.
---
 src/ftbench.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/ftbench.c b/src/ftbench.c
index 836c501..2ef9e9b 100644
--- a/src/ftbench.c
+++ b/src/ftbench.c
@@ -172,7 +172,7 @@
 
 
   /*
-   * Dummy face requester (the face object is already loaded)
+   * Face requester for cache testing
    */
 
   static FT_Error
@@ -183,10 +183,9 @@
   {
     FT_UNUSED( face_id );
     FT_UNUSED( library );
+    FT_UNUSED( request_data );
 
-    *aface = (FT_Face)request_data;
-
-    return FT_Err_Ok;
+    return get_face( aface );
   }
 
 
@@ -1365,7 +1364,7 @@
                      0,
                      max_bytes,
                      face_requester,
-                     face,
+                     NULL,
                      &cache_man );
 
     font_type.face_id = (FTC_FaceID)1;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]