glob2-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[glob2-devel] Pull request policy


From: Stéphane Magnenat
Subject: [glob2-devel] Pull request policy
Date: Sat, 28 Dec 2019 16:42:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2

Hello,

How should we organise with pull requests? Do we want at least one person to review before merging?

I saw that richelbilderbeek contributed several elements, including fixes in scons, CI scripts, and a Qt build script in one PR [1], and I did a review. The first two are for sure highly valuable, the Qt build script I am not sure that it is helpful, but I won't keep people from contributing if they want to, if it is useful for them.

On my side, I added out of source build to scons [2] that I would like to merge, if someone wants to review it is welcome.

cheers,

Stéphane

[1] https://github.com/Globulation2/glob2/pull/6

[2] https://github.com/Globulation2/glob2/pull/7

--
http://stephane.magnenat.net




reply via email to

[Prev in Thread] Current Thread [Next in Thread]