[Grep-devel] build: ensure no VLA is used

[Jim Meyering]

I'm pushing these to prevent use of VLAs:

>From 06cec163ded9e6927ab6cc86bff6530302a107c6 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 20 Jan 2019 21:08:24 -0800
Subject: [PATCH 1/2] build: update gnulib to latest

---
 gnulib | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnulib b/gnulib
index 4652c7b..5b490ef 160000
--- a/gnulib
+++ b/gnulib
@@ -1 +1 @@
-Subproject commit 4652c7bafa60332145f1e05a7de5f48e1bc56226
+Subproject commit 5b490ef07f257a5dd41fc0b351c1a387b8a8f89c
-- 
2.20.1.2.gb21ebb671b


>From 8df79c9fa79b6ce86fec0342f779125c85ff2f12 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sun, 20 Jan 2019 22:19:54 -0800
Subject: [PATCH 2/2] build: ensure no VLA is used

Cause developer builds to fail for any use of a VLA.
VLAs (variable length arrays) limit portability.
* configure.ac (nw): Remove -Wvla from the list of disabled warnings,
thus enabling the warning when configured with --enable-gcc-warnings.
(GNULIB_NO_VLA) Define, disabling use of VLAs in gnulib.  This commit
is functionally equivalent to coreutils' v8.30-44-gd26dece5d.
---
 configure.ac | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 1bbfc4f..4999840 100644
--- a/configure.ac
+++ b/configure.ac
@@ -94,6 +94,10 @@ AC_TYPE_SIZE_T
 AC_C_CONST
 gl_INIT

+# Ensure VLAs are not used.
+# Note -Wvla is implicitly added by gl_MANYWARN_ALL_GCC
+AC_DEFINE([GNULIB_NO_VLA], [1], [Define to 1 to disable use of VLAs])
+
 # The test suite needs to know if we have a working perl.
 # FIXME: this is suboptimal.  Ideally, we would be able to call gl_PERL
 # with an ACTION-IF-NOT-FOUND argument ...
@@ -134,7 +138,6 @@ if test "$gl_gcc_warnings" = yes; then
   nw="$nw -Wundef"                  # Warns on '#if GNULIB_FOO' etc in gnulib
   nw="$nw -Wsystem-headers"         # Don't let system headers trigger warnings
   nw="$nw -Wpadded"                 # Our structs are not padded
-  nw="$nw -Wvla"                    # warnings in gettext.h
   nw="$nw -Wstack-protector"        # generates false alarms for useful code
   nw="$nw -Wswitch-default"         # Too many warnings for now
   nw="$nw -Wunsafe-loop-optimizations" # OK to suppress unsafe optimizations
-- 
2.20.1.2.gb21ebb671b