guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

375/416: services: mpd: Use proper records for user and group fields.


From: guix-commits
Subject: 375/416: services: mpd: Use proper records for user and group fields.
Date: Fri, 14 Apr 2023 15:26:28 -0400 (EDT)

apteryx pushed a commit to branch master
in repository guix.

commit 865df7f080c64960f349fff79088427889e6c492
Author: Bruno Victal <mirai@makinata.eu>
AuthorDate: Sun Mar 26 19:41:32 2023 +0100

    services: mpd: Use proper records for user and group fields.
    
    Deprecate using strings for these fields and prefer user-account
    (resp. user-group) instead to avoid duplication within account-service-type.
    
    Fixes #61570 <https://issues.guix.gnu.org/61570>.
    
    * gnu/services/audio.scm (%mpd-user, %mpd-group)
    (mpd-serialize-user-account, mpd-serialize-user-group)
    (mpd-user-sanitizer, mpd-group-sanitizer): New variables.
    (mpd-configuration)[user]: Use user-account as value type.
    Sanitize via mpd-user-sanitizer.
    [group]: Use user-group as value type.
    Sanitize via mpd-group-sanitizer.
    (mpd-shepherd-service): Adjust accordingly.
    (mpd-accounts): Likewise.
    * doc/guix.texi (Audio Services)[Music Player Daemon]: Likewise.
    
    Signed-off-by: Liliana Marie Prikler <liliana.prikler@gmail.com>
---
 gnu/services/audio.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/services/audio.scm b/gnu/services/audio.scm
index 9ad63328c6..690409b7a1 100644
--- a/gnu/services/audio.scm
+++ b/gnu/services/audio.scm
@@ -140,6 +140,14 @@
 (define list-of-symbol?
   (list-of symbol?))
 
+;; Helpers for deprecated field types, to be removed later.
+(define %lazy-group (make-symbol "%lazy-group"))
+
+(define (%set-user-group user group)
+  (user-account
+   (inherit user)
+   (group (user-group-name group))))
+
 
 ;;;
 ;;; MPD



reply via email to

[Prev in Thread] Current Thread [Next in Thread]