47/96: services: agetty: 'term-console' succeeds by default.

[guix-commits]

apteryx pushed a commit to branch core-updates
in repository guix.

commit 2886a59d182aab5c3525046e1aa84e2281f12426
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Mon Apr 17 15:02:29 2023 +0200

    services: agetty: 'term-console' succeeds by default.
    
    Previously, on a typical setup without "console=ttyS0" or similar in
    'kernel-arguments', the 'term-console' Shepherd service would always be
    marked as failing to start.  This is undesirable because it raises a
    false alarm: the service is expected to do nothing in this case.
    
    This patch instead marks it as succeeding and logs a message explaining
    it's doing nothing.
    
    * gnu/services/base.scm (agetty-shepherd-service): In 'start' method,
    succeed when TTY is #f and print a message.
---
 gnu/services/base.scm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/gnu/services/base.scm b/gnu/services/base.scm
index e5c6bf5335..dfc7571e55 100644
--- a/gnu/services/base.scm
+++ b/gnu/services/base.scm
@@ -1178,7 +1178,13 @@ to use as the tty.  This is primarily useful for 
headless systems."
                            #$@(if term
                                   #~(#$term)
                                   #~())))
-                    (const #f))                   ; never start.
+                    #$(if tty
+                          #~(const #f)         ;always fail to start
+                          #~(lambda _          ;succeed, but don't do anything
+                              (format #t "~a: \
+no serial port console requested; doing nothing~%"
+                                      '#$(car provision))
+                              'idle)))
                 args)))))
       (stop #~(make-kill-destructor))))))