[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
02/08: substitute: Rethrow with 'raise-exception', not 'throw'.
From: |
guix-commits |
Subject: |
02/08: substitute: Rethrow with 'raise-exception', not 'throw'. |
Date: |
Mon, 22 May 2023 11:11:45 -0400 (EDT) |
civodul pushed a commit to branch master
in repository guix.
commit 3f59fd6d114548480c719d4b8f8509bdf3e8dcca
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Mon May 22 12:15:14 2023 +0200
substitute: Rethrow with 'raise-exception', not 'throw'.
Rethrowing with 'throw' doesn't work as intended when the exception
being rethrown is a SRFI-34 exception.
Fixes <https://issues.guix.gnu.org/55820>.
* guix/scripts/substitute.scm (kind-and-args-exception?): New variable.
(call-with-cached-connection): Rewrite using 'guard' instead of 'catch'
and 'raise' instead of 'throw'.
(system-error?): Use 'kind-and-args-exception?' instead of local
definition.
---
guix/scripts/substitute.scm | 67 ++++++++++++++++++++++++---------------------
1 file changed, 36 insertions(+), 31 deletions(-)
diff --git a/guix/scripts/substitute.scm b/guix/scripts/substitute.scm
index 2bbe045364..0b27ebb0fc 100755
--- a/guix/scripts/substitute.scm
+++ b/guix/scripts/substitute.scm
@@ -400,34 +400,41 @@ server certificates."
(drain-input socket)
socket))))))))
+(define kind-and-args-exception?
+ (exception-predicate &exception-with-kind-and-args))
+
(define (call-with-cached-connection uri proc)
(let ((port (open-connection-for-uri/cached uri
#:verify-certificate? #f)))
- (catch #t
- (lambda ()
- (proc port))
- (lambda (key . args)
- ;; If PORT was cached and the server closed the connection in the
- ;; meantime, we get EPIPE. In that case, open a fresh connection
- ;; and retry. We might also get 'bad-response or a similar
- ;; exception from (web response) later on, once we've sent the
- ;; request, or a ERROR/INVALID-SESSION from GnuTLS.
- (if (or (and (eq? key 'system-error)
- (= EPIPE (system-error-errno `(,key ,@args))))
- (and (eq? key 'gnutls-error)
- (memq (first args)
- (list error/invalid-session
-
- ;; XXX: These two are not properly handled in
- ;; GnuTLS < 3.7.3, in
- ;; 'write_to_session_record_port'; see
- ;; <https://bugs.gnu.org/47867>.
- error/again error/interrupted)))
- (memq key '(bad-response bad-header bad-header-component)))
- (proc (open-connection-for-uri/cached uri
- #:verify-certificate? #f
- #:fresh? #t))
- (apply throw key args))))))
+ (guard (c ((kind-and-args-exception? c)
+ (let ((key (exception-kind c))
+ (args (exception-args c)))
+ ;; If PORT was cached and the server closed the connection in
the
+ ;; meantime, we get EPIPE. In that case, open a fresh
connection
+ ;; and retry. We might also get 'bad-response or a similar
+ ;; exception from (web response) later on, once we've sent the
+ ;; request, or a ERROR/INVALID-SESSION from GnuTLS.
+ (if (or (and (eq? key 'system-error)
+ (= EPIPE (system-error-errno `(,key ,@args))))
+ (and (eq? key 'gnutls-error)
+ (memq (first args)
+ (list error/invalid-session
+
+ ;; XXX: These two are not properly
handled in
+ ;; GnuTLS < 3.7.3, in
+ ;; 'write_to_session_record_port';
see
+ ;; <https://bugs.gnu.org/47867>.
+ error/again error/interrupted)))
+ (memq key '(bad-response bad-header
bad-header-component)))
+ (proc (open-connection-for-uri/cached uri
+
#:verify-certificate? #f
+ #:fresh? #t))
+ (raise c))))
+ (#t
+ ;; An exception that's not handled here, such as
+ ;; '&http-get-error'. Re-raise it.
+ (raise c)))
+ (proc port))))
(define-syntax-rule (with-cached-connection uri port exp ...)
"Bind PORT with EXP... to a socket connected to URI."
@@ -563,12 +570,10 @@ STATUS-PORT."
(bytevector->nix-base32-string expected)
(bytevector->nix-base32-string actual)))))))
-(define system-error?
- (let ((kind-and-args? (exception-predicate &exception-with-kind-and-args)))
- (lambda (exception)
- "Return true if EXCEPTION is a Guile 'system-error exception."
- (and (kind-and-args? exception)
- (eq? 'system-error (exception-kind exception))))))
+(define (system-error? exception)
+ "Return true if EXCEPTION is a Guile 'system-error exception."
+ (and (kind-and-args-exception? exception)
+ (eq? 'system-error (exception-kind exception))))
(define network-error?
(let ((kind-and-args? (exception-predicate &exception-with-kind-and-args)))
- branch master updated (849286ba66 -> dff1689bb3), guix-commits, 2023/05/22
- 05/08: gnu: python-txtorcon: Fix failing build., guix-commits, 2023/05/22
- 06/08: gnu: python-txtorcon: Run guix style., guix-commits, 2023/05/22
- 04/08: gnu: homebank: Update to 5.6.3., guix-commits, 2023/05/22
- 03/08: gnu: Add opensycl., guix-commits, 2023/05/22
- 07/08: gnu: python-txtorcon: Update to 23.0.0., guix-commits, 2023/05/22
- 08/08: gnu: oil: Update to 0.15.0., guix-commits, 2023/05/22
- 01/08: gnu: lcov: Patch reference to 'find' command., guix-commits, 2023/05/22
- 02/08: substitute: Rethrow with 'raise-exception', not 'throw'.,
guix-commits <=