[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
14/67: gnu: findutils: Move test-strerror_r from XFAIL to skip on the Hu
From: |
guix-commits |
Subject: |
14/67: gnu: findutils: Move test-strerror_r from XFAIL to skip on the Hurd. |
Date: |
Tue, 18 Jul 2023 10:57:00 -0400 (EDT) |
janneke pushed a commit to branch hurd-team
in repository guix.
commit f1f6b17eaf223cc3864f20b38bf581bb8e1de58d
Author: Janneke Nieuwenhuizen <janneke@gnu.org>
AuthorDate: Fri Jun 2 16:47:36 2023 +0200
gnu: findutils: Move test-strerror_r from XFAIL to skip on the Hurd.
* gnu/packages/base.scm (findutils)[arguments]: When building natively on
the
Hurd, remove #:make-flags as "test-strerror_r" fails non-deterministically.
Instead, add 'skip-test' phase and skip it.
---
gnu/packages/base.scm | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 00e59e6f46..14479c4951 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -340,10 +340,16 @@ interactive means to merge two files.")
(substitute* '("tests/xargs/verbose-quote.sh"
"tests/find/exec-plus-last-file.sh")
(("#!/bin/sh")
- (string-append "#!" (which "sh")))))))
- #:make-flags ,(if (target-hurd?)
- ''("XFAIL_TESTS=test-strerror_r")
- ''())))
+ (string-append "#!" (which "sh"))))))
+ ,@(if (system-hurd?)
+ '((add-after 'unpack 'skip-tests
+ (lambda _
+ (substitute*
+ ;; This test fails non-deterministically
+ "gnulib-tests/test-strerror_r.c"
+ (("(^| )main *\\(.*" all)
+ (string-append all "{\n exit (77);//"))))))
+ '()))))
(synopsis "Operating on files matching given criteria")
(description
"Findutils supplies the basic file directory searching utilities of the
- 41/67: gnu: cmake-minimal: Skip tests on the Hurd., (continued)
- 41/67: gnu: cmake-minimal: Skip tests on the Hurd., guix-commits, 2023/07/18
- 36/67: gnu: ruby-2.6: Skip test on the Hurd., guix-commits, 2023/07/18
- 39/67: gnu: zstd: Skip tests when building for the Hurd., guix-commits, 2023/07/18
- 51/67: gnu: guile-2.0: Skip failing tests on the Hurd., guix-commits, 2023/07/18
- 64/67: DRAFT hurd-boot: Support second boot., guix-commits, 2023/07/18
- 58/67: self: Build gnu/packages/*.go in 26 steps on the Hurd., guix-commits, 2023/07/18
- 50/67: gnu: po4a: Skip failing test on the Hurd., guix-commits, 2023/07/18
- 52/67: hurd: Support system init in /libexec/runsystem., guix-commits, 2023/07/18
- 02/67: gnu: commencement: Add automake-boot0., guix-commits, 2023/07/18
- 11/67: gnu: coreutils: Skip hanging and failing test on the Hurd., guix-commits, 2023/07/18
- 14/67: gnu: findutils: Move test-strerror_r from XFAIL to skip on the Hurd.,
guix-commits <=
- 18/67: gnu: openssl: Build fix for the Hurd., guix-commits, 2023/07/18
- 28/67: gnu: git: Skip failing test on the Hurd., guix-commits, 2023/07/18
- 38/67: gnu: swig: Skip tests when building for the Hurd., guix-commits, 2023/07/18
- 34/67: gnu: cairo: Support building for the Hurd., guix-commits, 2023/07/18
- 32/67: gnu: parted: Disable tests for the Hurd., guix-commits, 2023/07/18
- 40/67: gnu: cmake-bootstrap: Fix build for the Hurd., guix-commits, 2023/07/18
- 46/67: gnu: ghostscript: Fix build for the Hurd., guix-commits, 2023/07/18
- 63/67: DRAFT hurd: Support second boot., guix-commits, 2023/07/18
- 44/67: gnu: guile-git: Skip http proxy test on the Hurd., guix-commits, 2023/07/18
- 67/67: locale: Set %default-locale-definitions to glibc/hurd on the Hurd., guix-commits, 2023/07/18