[no subject]

[Ludovic Courtès]

branch: master
commit baf94beac8b6f37428fe53c1e811dc222e8952f3
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Tue Aug 22 22:05:32 2023 +0200

    Remove unused variables.
    
    * src/cuirass/base.scm (build-derivation=?): Remove.
    * src/cuirass/database.scm (%exec-query/bind)[string-literal?]: Remove.
    * src/cuirass/rss.scm (build->rss-item): Remove 'id'.
    * src/cuirass/templates.scm (specifications-table): Remove 'eval'.
    (evaluation-info-table): Use 'dropdown-id', not 'id'.
---
 src/cuirass/base.scm      | 5 -----
 src/cuirass/database.scm  | 3 ---
 src/cuirass/rss.scm       | 1 -
 src/cuirass/templates.scm | 6 ++----
 4 files changed, 2 insertions(+), 13 deletions(-)

diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
index fb41ab0..53f7988 100644
--- a/src/cuirass/base.scm
+++ b/src/cuirass/base.scm
@@ -508,11 +508,6 @@ updating the database accordingly."
     (_
      (log-debug "build event: ~s" event))))
 
-(define (build-derivation=? build1 build2)
-  "Return true if BUILD1 and BUILD2 correspond to the same derivation."
-  (string=? (build-derivation build1)
-            (build-derivation build2)))
-
 (define (clear-build-queue)
   "Reset the status of builds in the database that are marked as \"started\".
 This procedure is meant to be called at startup."
diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm
index 5fce8f3..4d729c8 100644
--- a/src/cuirass/database.scm
+++ b/src/cuirass/database.scm
@@ -239,9 +239,6 @@
   (lambda (s)
     ;; Expand to an 'exec-query' call where the query string has
     ;; interspersed question marks and the argument list is separate.
-    (define (string-literal? s)
-      (string? (syntax->datum s)))
-
     (define (interleave a b)
       (if (null? b)
           (list (car a))
diff --git a/src/cuirass/rss.scm b/src/cuirass/rss.scm
index 6cd4d35..a4c1f4e 100644
--- a/src/cuirass/rss.scm
+++ b/src/cuirass/rss.scm
@@ -137,7 +137,6 @@ list ATTRS and the child nodes in BODY."
 (define* (build->rss-item build)
   "Convert BUILD into an RSS <item> node."
   (let* ((url (build-details-url build))
-         (id (build-id build))
          (job-name (build-job-name build))
          (specification (build-specification-name build))
          (weather (build-current-weather build))
diff --git a/src/cuirass/templates.scm b/src/cuirass/templates.scm
index de0745c..66404c4 100644
--- a/src/cuirass/templates.scm
+++ b/src/cuirass/templates.scm
@@ -415,9 +415,7 @@ system whose names start with " (code "guile-") ":" (br)
                      (td
                       ,@(let* ((name (specification-name spec))
                                (dashboard-name
-                                (string-append "Dashboard " name))
-                               (eval (and=> (spec->latest-eval-ok name)
-                                            (cut assq-ref <> #:evaluation))))
+                                (string-append "Dashboard " name)))
                           `((a (@ (href "/eval/latest/dashboard?spec="
                                         ,(uri-encode name)))
                                (div
@@ -1020,7 +1018,7 @@ the existing SPEC otherwise."
                                      (string-append "Options evaluation "
                                                     (number->string id))))
                                 `(div
-                                  (@ (id ,id)
+                                  (@ (id ,dropdown-id)
                                      (title ,name)
                                      (aria-label ,name)
                                      (class "dropdown d-inline-block ml-2"))