guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

01/02: guix: git: Avoid touching the network unless needed in 'reference


From: guix-commits
Subject: 01/02: guix: git: Avoid touching the network unless needed in 'reference-available?'.
Date: Tue, 29 Aug 2023 15:28:05 -0400 (EDT)

apteryx pushed a commit to branch master
in repository guix.

commit a789dd58656d5f7f1b8edf790d77753fc71670af
Author: Simon Tournier <zimon.toutoune@gmail.com>
AuthorDate: Thu Aug 17 16:09:16 2023 +0200

    guix: git: Avoid touching the network unless needed in 
'reference-available?'.
    
    * guix/git/scm (reference-available?): Use the resolve-reference procedure
    to determine whether the reference exists in the local Git checkout.
    
    Signed-off-by: Maxim Cournoyer <maxim.cournoyer@gmail.com>
---
 guix/git.scm | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/guix/git.scm b/guix/git.scm
index dbc3b7caa7..ebe2600209 100644
--- a/guix/git.scm
+++ b/guix/git.scm
@@ -360,17 +360,8 @@ dynamic extent of EXP."
 (define (reference-available? repository ref)
   "Return true if REF, a reference such as '(commit . \"cabba9e\"), is
 definitely available in REPOSITORY, false otherwise."
-  (match ref
-    ((or ('commit . commit)
-         ('tag-or-commit . (? commit-id? commit)))
-     (let ((len (string-length commit))
-           (oid (string->oid commit)))
-       (false-if-git-not-found
-        (->bool (if (< len 40)
-                    (object-lookup-prefix repository oid len OBJ-COMMIT)
-                    (commit-lookup repository oid))))))
-    (_
-     #f)))
+  (false-if-git-not-found
+   (->bool (resolve-reference repository ref))))
 
 (define (clone-from-swh url tag-or-commit output)
   "Attempt to clone TAG-OR-COMMIT (a string), which originates from URL, using



reply via email to

[Prev in Thread] Current Thread [Next in Thread]