guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

branch master updated: home: services: Fix regression in generated ‘on-f


From: guix-commits
Subject: branch master updated: home: services: Fix regression in generated ‘on-first-login’ script.
Date: Fri, 27 Oct 2023 10:52:35 -0400

This is an automated email from the git hooks/post-receive script.

snape pushed a commit to branch master
in repository guix.

The following commit(s) were added to refs/heads/master by this push:
     new 2de3004267 home: services: Fix regression in generated 
‘on-first-login’ script.
2de3004267 is described below

commit 2de30042674197fe451c220745186e36465d06e2
Author: Rostislav Svoboda <Rostislav.Svoboda@gmail.com>
AuthorDate: Tue Oct 24 16:08:10 2023 +0200

    home: services: Fix regression in generated ‘on-first-login’ script.
    
    Fixes <https://issues.guix.gnu.org/66659>.
    
    Fixes a regression introduced in 6b0a32196982a0a2f4dbb59d35e55833a5545ac6. 
The
    first attempt in e098ba2f499bbddfea50c85058e4077e39b85513 to fix this issue 
didn't work.
    
    * gnu/home/services.scm (compute-on-first-login-script): Add
    ‘begin *unspecified*’ around #$@gexps.
    
    Change-Id: I14339ad684ffe93e692e507b57dcd221d96210ef
    Signed-off-by: Clément Lassieur <clement@lassieur.org>
---
 gnu/home/services.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/home/services.scm b/gnu/home/services.scm
index 282fed74c1..44f585aff5 100644
--- a/gnu/home/services.scm
+++ b/gnu/home/services.scm
@@ -435,7 +435,10 @@ activation.")))
          ;; after complete logout/reboot.
          (if (file-exists? xdg-runtime-dir)
              (when (claim-first-run flag-file-path)
-               (begin #$@gexps))            ;GEXPS can be empty, hence 'begin'
+               ;; GEXPS can be empty, hence 'begin *unspecified*'. Having just
+               ;; 'begin' without '*unspecified*' leads to
+               ;; "Syntax error: ... sequence of zero expressions in form 
(begin)"
+               (begin *unspecified* #$@gexps))
              ;; TRANSLATORS: 'on-first-login' is the name of a service and
              ;; shouldn't be translated
              (warning (G_ "XDG_RUNTIME_DIR doesn't exists, on-first-login 
script



reply via email to

[Prev in Thread] Current Thread [Next in Thread]